Add margin control for menu label

[cristian-ungureanu]

Summary

• Adds a new margin control for the Menu Icon component

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

• See if the control applies properly in the customizer and on the front end

Closes Codeinwp/neve-pro-addon#2095.

[github-actions[bot]]

Plugin build for f675b425a25059c07a61d079afe4433d1d573a87 is ready :bellhop_bell:!

• Download build

[Skystream96]

Hello @cristian-ungureanu ,

I tested this one and everything seems to be fine for PX and % Values. If you use the EM option, then the settings won't be saved after you exit the customizer.

Here is a screencast showing the behavior:

https://user-images.githubusercontent.com/82535909/182672823-8db168da-2989-4e60-a431-735c014d37a3.mp4

I also noticed that the "Link Elements" option is not holding on to the setting but resets every time you enter the customiser.

Steps to reproduce:

1. Enter the Layout Settings and observe the initial state of the "Link Elements" Options (linked, unlinked, linked)
2. Change one of them (the second one from unlinked to linked and change values)
3. Publish changes and exit Cusomizer
4. Enter the Customizer > Header > Menu Icon > Settings > Layout
5. Observe how the second item is again unlinked but the previous measurements remained.

Here is a screencast showing the behavior:

https://user-images.githubusercontent.com/82535909/182674665-65d68c20-08b4-4ad0-9dc7-7f401f7b4788.mp4

Please let me know if I can help with any additional info or anything else!

[cristian-ungureanu]

Thank you @Skystream96. Should be fixed now!

[Skystream96]

Hello @cristian-ungureanu ,

Tested again and now none of the options work.

https://user-images.githubusercontent.com/82535909/182911028-55980bbe-fe85-4fd0-99ec-e1caebb13fc6.mp4

Also, is the "link elements" behavior I previously mentioned the expected one? Or should I open another issue for it?

Thank you!

[cristian-ungureanu]

I can't replicate what you've reported @Skystream96. Everything seems good. Maybe there is some cached style on your end.

[Skystream96]

I can't replicate what you've reported @Skystream96. Everything seems good. Maybe there is some cached style on your end.

Hello @cristian-ungureanu ,

Indeed there seems to have been some caching issue on my end although I have tested in incognito mode too and the behavior remained.

Anyway, after clearing everything up and testing on more browsers I can say everything works as expected now!

Thank you!

[pirate-bot]

:tada: This PR is included in version 3.3.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: