neve icon indicating copy to clipboard operation
neve copied to clipboard

[Neve 3.3 test] Starter sites issues

Open irinelenache opened this issue 3 years ago • 14 comments

Description:

Here i'll post a list of inconsistencies between demosites.io and the actual import of FREE starter sites

Fitness gutenberg:

  • [x] Imported image is bigger than the others in the same section (On this page) Demosites: https://vertis.d.pr/AFMAXv Import: https://vertis.d.pr/vzjE0K

Photography gutenberg:

  • [x] Imported image is bigger than on demosites and breaks alignment - (On this page) Demosites: https://vertis.d.pr/QyRktG Import: https://vertis.d.pr/pwWPqt
  • [x] Imported image is bigger than the others in the same section (On this page) Demosites: https://vertis.d.pr/0OQtcq Import: https://vertis.d.pr/6Ae4i6
  • [x] Map image is missing on import (On this page) Demosites: https://vertis.d.pr/2jHnQQ Import: https://vertis.d.pr/5Trvzp

Architecture gutenberg:

  • [ ] Footer widgets missing on import Demosites: https://vertis.d.pr/feRUQC Import: https://vertis.d.pr/tkOxXc

Yoga studio:

  • [x] Icons background doesn't look ok on demosites only https://vertis.d.pr/Qwpvng , happens on every page that contains icons (Works fine on import)
  • [x] Images don't have the same dimensions on import (On this page) Demosites: https://vertis.d.pr/DGaCbb Import: https://vertis.d.pr/O1hlju https://vertis.d.pr/Qwpvng

Technical info

  • WordPress version: 6.0
  • Theme version: 3.3

ref: https://github.com/Codeinwp/neve-pro-addon/issues/1532

The starter sites i reviewed for now: Gutenberg - Web agency, Blogger, Neve 3, Fitness, Photography, Architecture studio, Lawyers, Yoga studio

Will come back with comments when i review more of them 🧐

irinelenache avatar Jul 04 '22 09:07 irinelenache

Wedding guttenberg:

  • [x] Section items are not aligned on import (On this page) Demosites: https://vertis.d.pr/HGg9ik Import: https://vertis.d.pr/6F81gQ

Pet shop:

  • [x] Sections have smaller height on import Demosites: https://vertis.d.pr/ozxQIO Import: https://vertis.d.pr/HxP8Sz
  • [x] Copyright component isn't visible because of its color, both on demosites and import https://vertis.d.pr/WYpvJ9
  • [x] Section columns have no margin on import Demosites: https://vertis.d.pr/OncNV5 Import: https://vertis.d.pr/JeWJPm
  • [x] Icons background doesn't look ok in demosites only (works fine on import) https://vertis.d.pr/E6xHBW

Restaurant:

  • [x] Images are not getting imported on Reservations page https://vertis.d.pr/tuvHNq

Music band:

  • [x] Section items are not aligned on import (On this page) Demosites: https://vertis.d.pr/6TCz8D Import: https://vertis.d.pr/Wxavss

Drone:

  • [x] Section items are not aligned on import (On this page) Demosites: https://vertis.d.pr/YFxX9V Import: https://vertis.d.pr/JVy1Mc
  • [x] Column items are getting out of the container (on demosites only) https://vertis.d.pr/4NXPs9
  • [ ] Product images have different size on import Demosites: https://vertis.d.pr/3Asgen Import: https://vertis.d.pr/gbCXsj

Fitness trainer:

  • [x] Icons background doesn't look ok in demosites only https://vertis.d.pr/Ipbd4y (On this page)
  • [x] Imported images are bigger on import and break the alignment (On this page) Demosites: https://vertis.d.pr/gKBkMo Import: https://vertis.d.pr/zjOAxO
  • [x] Columns content has no left-padding and the icons background doesn't look ok in demosites (On this page) Demosites: https://vertis.d.pr/SndC4p Import: https://vertis.d.pr/SndC4p

Vacation rental:

  • [x] Section items are not aligned on import (On this page and this page) Demosites: https://vertis.d.pr/Lh1THA Import: https://vertis.d.pr/ozKRou

✅ For now, all free starter sites made with gutenberg are reviewed

irinelenache avatar Jul 05 '22 11:07 irinelenache

Thanks for reporting all these @irinelenache. By scanning the bullets for each site in your comment I see many of them have a "technical" twist :) I believe that the fix for those would be to just re-define the values on the controls. Regarding the image sizing, I have no idea, but there might be a fix by the same way.

@mghenciu let me know how you see fit to approach this, and if you need any help of course.

JohnPixle avatar Jul 06 '22 17:07 JohnPixle

@JohnPixle @mghenciu Also tested the import of 10 starter sites (with Elementor as builder) and didn't encounter any problem for now, like misaligned things or missing ones. Will update here when i test more.

I wanted to mention that on the import, you get Elementor 3.6.7, so if we don't find any problems regarding how the imports look, can we update Elementor on demosites too?

irinelenache avatar Jul 07 '22 14:07 irinelenache

Tested most of the Elementor starter sites now and found a single problem:

Restaurant(gb):

Images are not getting imported on Reservations page https://vertis.d.pr/tuvHNq

^ Same happens for the Elementor one

irinelenache avatar Jul 08 '22 10:07 irinelenache

@irinelenache

I wanted to mention that on the import, you get Elementor 3.6.7, so if we don't find any problems regarding how the imports look, can we update Elementor on demosites too?

Yes, this would be great actually, we need a newer version of Elementor in demosites 👍🏻

JohnPixle avatar Jul 08 '22 11:07 JohnPixle

Pro starter sites issues(gutenberg):

Craft beer:

  • [x] Missing woocommerce blocks on the homepage https://vertis.d.pr/zWMRv9 https://vertis.d.pr/y8TATb
  • [x] Misaligned columns on the about page https://vertis.d.pr/nZjoQl and on the contact page https://vertis.d.pr/RSQWKm
  • [x] Columns spacing is missing on the about page https://vertis.d.pr/Aad4vr

Business:

  • [x] Our services section columns have no padding Demosites: https://vertis.d.pr/pp0uEB Import: https://vertis.d.pr/uL8YxT

Medicare:

  • [x] Different spacing for the gallery in the About page Demosites: https://vertis.d.pr/bIl1ad Import: https://vertis.d.pr/Y5aFXf

Speed:

  • [x] Misaligned columns on the about page https://vertis.d.pr/bEqC2G

Accounting:

  • [x] "Why choose us" section on homepage is different on import Demosites: https://vertis.d.pr/qh0DeR Import: https://vertis.d.pr/5m99Xx
  • [x] "Case studies" section columns on homepage are misaligned https://vertis.d.pr/zKvVc0
  • [x] ^ Same for the Services page https://vertis.d.pr/tN4Bgf

Audio books:

  • [ ] Images with different size on the homepage Demosites: https://vertis.d.pr/u4CQZw Import: https://vertis.d.pr/IwmtYT

Architecture studio:

  • [x] Images not getting imported on the Expertise page https://vertis.d.pr/yzAprK
  • [x] There is a space between images on the Home alt page Demosites: https://vertis.d.pr/rDfnQa Import: https://vertis.d.pr/HjjrrO

Personal blog:

  • [x] Icons background doesn't look ok in demosites https://vertis.d.pr/fuCPsP (On homepage)
  • [x] Images misaligned on import on the contact page https://vertis.d.pr/jAjvrh

Fishing and hunting:

  • [x] Images misaligned on import on the About page https://vertis.d.pr/ZdIUa0

Conference:

  • [x] Icons background doesn't look on in demosites https://vertis.d.pr/qRxXVl (On homepage)
  • [x] Icons misaligned on import https://vertis.d.pr/2nNJx1 (On homepage)
  • [x] Headings background looks different on import (On schedule page) Demosites: https://vertis.d.pr/9LhPD5 Import: https://vertis.d.pr/IhaVCT https://vertis.d.pr/essZfZ
  • [x] Misaligned images on import https://vertis.d.pr/fgQ5cq (On about page)
  • [x] Misaligned images on import https://vertis.d.pr/4kckHM (On the venue page)

University:

  • [x] Icons background doesn't look ok in demosites https://vertis.d.pr/NoR7vE (On homepage)
  • [x] Icons missing spacing on import https://vertis.d.pr/8c7oeb (On homepage)
  • [x] Icons and text have different positions on import (On courses page). Also, the section has different spacing Demosites: https://vertis.d.pr/8Mo9XA Import: https://vertis.d.pr/8XiIAb
  • [x] Section columns have different spacing on import (On about page) Demosites: https://vertis.d.pr/wBK8Ik Import: https://vertis.d.pr/J2Inqj

Resume 2:

  • [x] Icons background doesn't look ok in demosites https://vertis.d.pr/sK5GYc (On homepage)
  • [x] Section columns misaligned on import https://vertis.d.pr/Oa1oWR (On the about page)

Museum:

  • [x] No padding on section columns on import https://vertis.d.pr/e4arG3 (On the homepage and Exhibitions page)
  • [x] Misaligned section columns on import https://vertis.d.pr/6RVJc0 (On the homepage and Exhibitions page)
  • [x] Misaligned gallery images on Exhibition details page Demosites: https://vertis.d.pr/dJ7VZR Import: https://vertis.d.pr/CBGlIY
  • [x] Misaligned section column on import https://vertis.d.pr/YYSWl8 (On the about page)

Product launch:

  • [x] Icons background doesn't look ok on demosites https://vertis.d.pr/cs2Snt (On the homepage)
  • [x] Misaligned images on import https://vertis.d.pr/a6fjD0 (On the homepage)
  • [x] Section columns have no spacing on import (On the homepage) Demosites: https://vertis.d.pr/DS2rg2 Import: https://vertis.d.pr/pR0QM6

Industrial:

  • [x] Section with icons looks bad both on import and demosites (On homepage) Demosites: https://vertis.d.pr/Utsw1Z Import: https://vertis.d.pr/xhfaaD
  • [x] Section looks different on import (On Services page) Demosites: https://vertis.d.pr/KZs84i Import: https://vertis.d.pr/G4CGkA
  • [x] Section with icons looks bad both on import and demosites (On service details page) Demosites: https://vertis.d.pr/zhNv95 Import: https://vertis.d.pr/2gh4wD

✅ All gutenberg starter sites are reviewed now

irinelenache avatar Jul 08 '22 13:07 irinelenache

Hey @preda-bogdan, seems like there are some issues regarding the imports. Can you please have a look at this? If there are some actions related to the setup of the starter sites I think @mghenciu can help.

cristian-ungureanu avatar Jul 08 '22 13:07 cristian-ungureanu

@preda-bogdan , as promised, here are a few technical things we can look into:

  • [x] how woo blocks are rendered after import. For example on the Craft Beer site, the homepage has some Woo blocks (On Sale Products, Newest Products). After the import, the woo products are also imported, but on the homepage and in general, the woo blocks are not showing those products: Missing woocommerce blocks on the homepage https://vertis.d.pr/zWMRv9 https://vertis.d.pr/y8TATb Screenshot 2022-07-20 at 20 32 34

  • [x] Recipe Blog. Here the Recipes plugin is mandatory (as seen in the ss), but after the import, the plugin is not Active:

image Screenshot 2022-07-20 at 21 08 23

The other issues mentioned by Irinel, are builder related and I will fix them.

mghenciu avatar Jul 20 '22 18:07 mghenciu

Thank you @mghenciu I will start looking into those.

preda-bogdan avatar Jul 21 '22 10:07 preda-bogdan

@mghenciu I've fixed the mentioned issues inside the templates-patterns-collection plugin. You can test using the linked PRs for each issue reported.

Let me know if this solves the issues for you, also if you encounter other tech issues with regards to import I'll take care of them just tag me.

preda-bogdan avatar Jul 22 '22 14:07 preda-bogdan

@irinelenache when you have some time can you confirm that the PRs linked are solving the issues mentioned by @mghenciu for the technical side?

Thank you!

preda-bogdan avatar Jul 25 '22 09:07 preda-bogdan

Hey @preda-bogdan, feel free to close this issue if all the problems are resolved.

cristian-ungureanu avatar Aug 02 '22 07:08 cristian-ungureanu

Hey @preda-bogdan, feel free to close this issue if all the problems are resolved.

I'll focus on this issues today and get back with an update.

mghenciu avatar Aug 02 '22 09:08 mghenciu

All the issues are fixed now, on the mentioned Starter Sites.

With the exception of the Woo related issues where the image is different on import. I am not sure we can export/import that. It's not a big issue, just after import the images are squares. And on the Architecture demo, on import the widgets worked for me.

I think we can close this one, and retest in the next month.

mghenciu avatar Aug 04 '22 16:08 mghenciu