neve icon indicating copy to clipboard operation
neve copied to clipboard

Moving to google fonts API v2 [Needs Work]

Open UVLabs opened this issue 3 years ago • 3 comments

Summary

Move to Google fonts API v2

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • Before installing this build, create a test site and make use of the google fonts in typography settings in customizer.
  • Install this build
  • There should be no change to the current google font after installing this build
  • Change typography settings in customizer, font should change in preview and live site

Closes #2653

UVLabs avatar Feb 07 '22 19:02 UVLabs

Plugin build for 918010ed1ca15a52c8399e5dd1306e817192dc8e is ready :bellhop_bell:!

github-actions[bot] avatar Feb 07 '22 19:02 github-actions[bot]

@cristian-ungureanu I pushed up the latest code with the version toggle pane which isn't ideal and doesn't look good, but this is basically the logic we'd have to use if we want to enable this for only new users.

Unfortunately right now it doesn't seem like we have any proper function to detect if a user is truly a new user or not. I found this method but from what I understand this would always return true for old users as well because of the first few lines: https://github.com/Codeinwp/neve/blob/master/inc/core/core_loader.php#L49-L79

UVLabs avatar Feb 16 '22 05:02 UVLabs

@UVLabs Thank you for your research. I will move the issue back to the Backlog as it's not that urgent for now. We can have a look at some other time.

About the new user thing, the function must be rewritten to pass another option name. This way we can check if a user is new in different periods of time.

cristian-ungureanu avatar Feb 24 '22 09:02 cristian-ungureanu