feedzy-rss-feeds icon indicating copy to clipboard operation
feedzy-rss-feeds copied to clipboard

Add modify links action

Open girishpanchal30 opened this issue 1 year ago • 8 comments

Summary

In this PR, I've added modify links action to modify the <a></a> HTML attributes.

Screenshots

With Pro Version: https://tinyurl.com/2ypn2944 https://tinyurl.com/23qrd67z

Without Pro version: https://tinyurl.com/27xpoqg2 https://tinyurl.com/2b3gelle

Check before Pull Request is ready:

  • [ ] I have written a test and included it in this PR
  • [x] I have run all tests and they pass
  • [x] The code passes when running the PHP CodeSniffer
  • [x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
  • [x] Security and Sanitization requirements have been followed
  • [x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/647

girishpanchal30 avatar Aug 29 '24 06:08 girishpanchal30

Plugin build for 08a424c768d3e7a79db145888215a4bcda7c00df is ready :bellhop_bell:!

pirate-bot avatar Aug 29 '24 06:08 pirate-bot

@girishpanchal30, thank you for taking care!

Here are my findings:

  • there are some weird characters appearing for certain parts of the content (those were not links before) image

  • the panel doesn't have the same structure as in your screenshot: image

  • I set the links to open in the same tab and be nofollow, but this is not respected on the frontend:

image image

live behavior: https://overdodevelopment.s1-tastewp.com/2024/08/30/8-mistakes-i-made-when-building-my-first-wordpress-plugin-using-ai-with-no-prior-development-experience/

AndreeaCristinaRadacina avatar Aug 30 '24 14:08 AndreeaCristinaRadacina

@AndreeaCristinaRadacina

there are some weird characters appearing for certain parts of the content (those were not links before)

Can you please share Feed URL?

the panel doesn't have the same structure as in your screenshot:

It could be a cache issue on your end; everything looks fine from my side. Ref: https://tinyurl.com/25lj2l7p

girishpanchal30 avatar Aug 31 '24 08:08 girishpanchal30

@girishpanchal30 here is the feed: https://wpshout.com/feed

AndreeaCristinaRadacina avatar Sep 01 '24 18:09 AndreeaCristinaRadacina

@AndreeaCristinaRadacina I've fixed the mentioned issue with the latest commit.

girishpanchal30 avatar Sep 02 '24 04:09 girishpanchal30

@girishpanchal30 I am not sure why, but when using the Modify links action, the import no longer works:

image

Instance:

  • test
  • MrAP6PU)D@%jrDMD3qrTO#em
  • https://groovyfriends.s2-tastewp.com/wp-admin/users.php?id=2

Also, from the previous comment (just making sure), have you checked this too?

I set the links to open in the same tab and be nofollow, but this is not respected on the frontend:

AndreeaCristinaRadacina avatar Sep 03 '24 08:09 AndreeaCristinaRadacina

@AndreeaCristinaRadacina It seems issue with PHP 8, now it fixed with the latest commit.

girishpanchal30 avatar Sep 03 '24 08:09 girishpanchal30

@girishpanchal30, great! It works as expected now. Thank you!

AndreeaCristinaRadacina avatar Sep 03 '24 09:09 AndreeaCristinaRadacina

:tada: This PR is included in version 4.4.14 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

pirate-bot avatar Oct 29 '24 16:10 pirate-bot