school-finder icon indicating copy to clipboard operation
school-finder copied to clipboard

clicking map control for nearby schools reloads nearby schools unnecessarily

Open techieshark opened this issue 7 years ago • 0 comments

We're re-querying unnecessarily

To see it, search for a school (e.g. Darlinghurst Public) and clear your console. No nearby schools are shown.

screen shot 2016-11-01 at 9 19 01 pm

Click to expand the nearby schools control. You'll see a query in the console. That's fine, since it's checking the 'show nearby schools' checkbox for you.

screen shot 2016-11-01 at 9 19 09 pm

Click to collapse the nearby schools control. This shouldn't do reload the nearby schools since they've already been loaded and the user hasn't un-checked the 'show nearby schools' checkbox, but you will notice a new SELECT query in the console.

screen shot 2016-11-01 at 9 19 16 pm

In addition to running queries when we don't need to, the map unloads and loads the set of nearby schools, so you notice them flicker on the map.

techieshark avatar Nov 02 '16 04:11 techieshark