robo-paracept icon indicating copy to clipboard operation
robo-paracept copied to clipboard

Fix HTML report merging for multiple suites

Open reinholdfuereder opened this issue 2 years ago • 3 comments

Fixes https://github.com/Codeception/robo-paracept/issues/69

So far only the suites of the first HTML report were in the final merged HTML report. And when the first HTML report (luckily) already contained all suites, then all tests from the other HTML reports were always merged into the first suite (instead of the same non-first one).

reinholdfuereder avatar Apr 21 '22 11:04 reinholdfuereder

Thanks a lot, I still have a problem, with duplicate suite Capture d’écran 2022-04-28 à 11 34 57

And in a parallel run context, each run has an execution time The final merge of the reports aggregates each of the reports However, in my opinion, the execution time of the final merge should be the execution time of the longest run and not the sum of the execution times of each run

Would it be possible to do it in this PR, or am I opening a new issue?

ccsuperstar avatar Apr 28 '22 09:04 ccsuperstar

Thanks a lot, I still have a problem, with duplicate suite ...

And in a parallel run context, each run has an execution time The final merge of the reports aggregates each of the reports However, in my opinion, the execution time of the final merge should be the execution time of the longest run and not the sum of the execution times of each run

Would it be possible to do it in this PR, or am I opening a new issue?

Hm, I (as a complete newbie to this project) would say please open a new issue for that, because:

  • this (summing up of execution times) seems to be implemented on purpose like that (even the method comments claim that) and is not just a bug,
  • and I am also not really sure what users would expect: I think in fact both execution times (sum and maximum) may make sense or may be of interest?

reinholdfuereder avatar Apr 29 '22 06:04 reinholdfuereder

@reinholdfuereder Thank you for your contribution. Is it possible that you write a Unit Test which covers this new changes? Thanks a lot.

vansari avatar Jul 10 '22 19:07 vansari