module-asserts icon indicating copy to clipboard operation
module-asserts copied to clipboard

feat!: import lib-asserts, drop it as a dependency, require phpunit 11.5 automated releases

Open SamMousa opened this issue 6 months ago • 5 comments

SamMousa avatar Sep 04 '25 13:09 SamMousa

@TavoNiievez currently we have a weird dependency situation:

  1. module-asserts requires lib-asserts
  2. module-asserts requires codeception
  3. codeption requires lib-asserts
  4. codeception requires module-asserts

I've chosen to simplify it by importing lib-asserts into module-asserts (seems a bit overkill to have those 2 repos separated). My proposal is to deprecate lib-asserts and have this package provide it.

What do you think?

Edit: actually this is wrong; codeception only has a dev-require for this repo...

SamMousa avatar Sep 04 '25 14:09 SamMousa

The real problem is modules depending on Codeception and vice versa. https://github.com/Codeception/Codeception/issues/6164#issuecomment-822047204 In a perfect world, modules would be independent of Codeception, but in some cases this is difficult to achieve.

TavoNiievez avatar Sep 04 '25 14:09 TavoNiievez

In a perfect world, modules would be independent of Codeception, but in some cases this is difficult to achieve.

Yeah, the whole module system is so complicated:

  • Dependencies
  • Conflicts
  • Partial modules
  • Dependent modules :-|

SamMousa avatar Sep 05 '25 08:09 SamMousa

@SamMousa Do you still plan to integrate lib-asserts into this repo?

W0rma avatar Oct 23 '25 05:10 W0rma

Honestly, the mess of circular dependencies made it so that a simple upgrade already took me a day without much results and I'm not inclined to spend more.

SamMousa avatar Oct 23 '25 05:10 SamMousa