gamut icon indicating copy to clipboard operation
gamut copied to clipboard

feat: Add ArrowUpHeavy icon

Open katiezutter opened this issue 2 months ago • 7 comments

Overview

Adds ArrowUpHeavy icon.

PR Checklist

  • [x] Related to designs: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1427-2744
  • [x] Related to JIRA ticket: LXP-7940
  • [x] I have run this code to verify it works
  • [ ] This PR includes unit tests for the code change
  • [ ] This PR includes testing instructions tests for the code change
  • [ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Visit https://tayra.codecademy.com/learner-builder/new?PR_ENV=le-pr-11556 as an Optimizely test user
  2. Check the icon on the submit button

PR Links and Envs

Repository PR Link
Mono Mono PR

katiezutter avatar Oct 22 '25 18:10 katiezutter

View your CI Pipeline Execution ↗ for commit 21365cc96f9281016b0bf0175f6be3f609aec5f3

Command Status Duration Result
nx run-many --target=verify --parallel=3 --all ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 31s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-22 18:26:42 UTC

nx-cloud[bot] avatar Oct 22 '25 18:10 nx-cloud[bot]

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

codecademydev avatar Oct 22 '25 18:10 codecademydev

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

speterson-cc avatar Oct 23 '25 14:10 speterson-cc

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4

katiezutter avatar Oct 23 '25 16:10 katiezutter

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4

is there a reason not to just use an up arrow that already exists in Gamut? you're free to add it locally to your project it just seems strange to me that we would need more than a few variants (and is visually confusing, imo). i also know this is coming from design so you're just the messenger here 😅

dreamwasp avatar Oct 23 '25 18:10 dreamwasp

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4

is there a reason not to just use an up arrow that already exists in Gamut? you're free to add it locally to your project it just seems strange to me that we would need more than a few variants (and is visually confusing, imo). i also know this is coming from design so you're just the messenger here 😅

@dreamwasp I'll ask Kat about this!!

katiezutter avatar Oct 23 '25 19:10 katiezutter

Designs have changed - closing!

katiezutter avatar Nov 07 '25 17:11 katiezutter