gamut icon indicating copy to clipboard operation
gamut copied to clipboard
verified publisher icon Codecademy

fix(FormError): remove unnecessary wrapper

Open jrood opened this issue 5 months ago • 3 comments

Overview

FormError has been a wrapper around ErrorSpan that does nothing. We can export the styled.span directly as FormError.

PR Checklist

  • [ ] Related to designs:
  • [ ] Related to JIRA ticket: [ABC-123]
  • [ ] I have run this code to verify it works
  • [ ] This PR includes unit tests for the code change
  • [ ] This PR includes testing instructions tests for the code change
  • [ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

jrood avatar Jul 31 '25 22:07 jrood

View your CI Pipeline Execution ↗ for commit 1c71f50cc72605cb9baa070473754d199a1ecc18

☁️ Nx Cloud last updated this comment at 2025-07-31 22:27:57 UTC

nx-cloud[bot] avatar Jul 31 '25 22:07 nx-cloud[bot]

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

codecademydev avatar Jul 31 '25 22:07 codecademydev

🚀 Styleguide deploy preview ready!

https://688bedffea6db08ef539bf69--gamut-preview.netlify.app

Deploy Logs

codecademydev avatar Jul 31 '25 22:07 codecademydev