gamut icon indicating copy to clipboard operation
gamut copied to clipboard

feat(Anchor + Button): allow both leading and trailing icons

Open LinKCoding opened this issue 5 months ago • 3 comments

Overview

Updates the Anchor and Button components to allow both leading and trailing icons

PR Checklist

  • [ ] Related to designs:
  • [x] Related to JIRA ticket: GM-1052
  • [x] I have run this code to verify it works
  • [ ] This PR includes unit tests for the code change
  • [x] This PR includes testing instructions tests for the code change
  • [x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to the Anchor story ?path=/docs/typography-anchor--docs&globals=viewport:responsive and scroll down to the "Icons" section
  2. See that the Anchor still work, and the icons render as expected
  3. Turn on dark mode and check styling
  4. Check that the new text makes sense
  5. Go to Button: ?path=/docs/atoms-buttons-button--docs and scroll to the "Inline icons" section
  6. See that the middle example now has both leading and trailing icons
  7. Turn on dark mode and check styling
  8. Check that the new text makes sense
  9. Go to Menu: /?path=/docs/molecules-menu--docs
  10. Check that Menu items can now have multiple icons, and right positioned icons (in the no role canvas), and render correctly
  11. ...
  12. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

LinKCoding avatar Jul 28 '25 14:07 LinKCoding

View your CI Pipeline Execution ↗ for commit 7e37ce16ab5b5a53e4b3f5b898541ab4e3b8ba8b


☁️ Nx Cloud last updated this comment at 2025-10-07 16:33:25 UTC

nx-cloud[bot] avatar Jul 28 '25 14:07 nx-cloud[bot]

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

codecademydev avatar Sep 15 '25 14:09 codecademydev