gamut
gamut copied to clipboard
feat(Dialog): a new optional prop for the close button
Overview
Added a new optional prop for the close button related to its tip.
PR Checklist
- [ ] Related to designs:
- [x] Related to JIRA ticket: ENT-233
- [x] I have run this code to verify it works
- [ ] This PR includes unit tests for the code change
- [ ] This PR includes testing instructions tests for the code change
- [ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories
Testing Instructions
- Run
yarn start - Visit http://localhost:6006/?path=/docs/molecules-modals-dialog--dialog
- A new prop
closeButtonTipTextshould be visible in the Code Playground section
PR Links and Envs
| Repository | PR Link | PR Env |
|---|---|---|
| LE Enterprise | LE Enterprise Link | LE Enterprise Env |
this looks great! could you open a PR with the
gamut-kitalpha package? there are instructions here on how to do that. we just like to make sure nothing is breaking + all tests are passing.will ✅ once that's done!
Hi @dreamwasp, here's a PR that uses this alpha version: https://github.com/codecademy-engineering/mono/pull/7110
📬Published Alpha Packages:
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]