gamut icon indicating copy to clipboard operation
gamut copied to clipboard

feat(Dialog): a new optional prop for the close button

Open ITZSHOAIB opened this issue 1 year ago • 4 comments

Overview

Added a new optional prop for the close button related to its tip.

PR Checklist

  • [ ] Related to designs:
  • [x] Related to JIRA ticket: ENT-233
  • [x] I have run this code to verify it works
  • [ ] This PR includes unit tests for the code change
  • [ ] This PR includes testing instructions tests for the code change
  • [ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Run yarn start
  • Visit http://localhost:6006/?path=/docs/molecules-modals-dialog--dialog
  • A new prop closeButtonTipText should be visible in the Code Playground section

PR Links and Envs

Repository PR Link PR Env
LE Enterprise LE Enterprise Link LE Enterprise Env

ITZSHOAIB avatar Jul 31 '24 16:07 ITZSHOAIB

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 31 '24 16:07 CLAassistant

this looks great! could you open a PR with the gamut-kit alpha package? there are instructions here on how to do that. we just like to make sure nothing is breaking + all tests are passing.

will ✅ once that's done!

Hi @dreamwasp, here's a PR that uses this alpha version: https://github.com/codecademy-engineering/mono/pull/7110

ITZSHOAIB avatar Aug 01 '24 14:08 ITZSHOAIB

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

codecademydev avatar Aug 14 '24 13:08 codecademydev