gamut icon indicating copy to clipboard operation
gamut copied to clipboard

dark overlay

Open BandanaKM opened this issue 2 years ago • 3 comments

Overview

Screen Shot 2022-08-10 at 1 31 50 PM

This change:

  • Modifies the Overlay's shroud prop to have color shadow-black-heavy as specified in the mocks (shown in the pic above)
  • Stephen mentioned that we want all overlays to have this opacity

PR Checklist

  • [x] Related to designs: https://www.figma.com/file/ReGfRNillGABAj5SlITalN/%F0%9F%93%90-Gamut?node-id=2449%3A3770
  • [x] Related to JIRA ticket: WEB-2060
  • [x] I have run this code to verify it works
  • [x] This PR includes unit tests for the code change
  • [x] This PR includes testing instructions tests for the code change
  • [x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

BandanaKM avatar Aug 29 '22 18:08 BandanaKM

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d2c0d3c1ce072ef03204e77cb0e9d9b09edbfa9e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Aug 29 '22 18:08 nx-cloud[bot]

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

codecademydev avatar Aug 29 '22 20:08 codecademydev