docs icon indicating copy to clipboard operation
docs copied to clipboard

New Entry: C++ Math Functions: `isfinite()`

Open Hitarth-Kothari opened this issue 2 years ago • 9 comments

Description

Closes #966

Created folder named isfinite at path : c++/concepts/math-functions/terms/ Created file named isfinite.md under isfinite, which inclued Term Entry requirements for isfinite()

Motivation: Issue #966

Type of Change

  • Adding a new entry

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

Hitarth-Kothari avatar Sep 07 '22 20:09 Hitarth-Kothari

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 07 '22 20:09 CLAassistant

@SSwiniarski I tried running yarn to fix some of these issues, but I keep getting an error Invalid configuration file content\cpp\concepts\math-functions\terms\sqrt\sqrt.md: Cannot find module '@codecademy/prettier-config' Any idea how to fix?

Hitarth-Kothari avatar Sep 08 '22 16:09 Hitarth-Kothari

@SSwiniarski I tried running yarn to fix some of these issues, but I keep getting an error Invalid configuration file content\cpp\concepts\math-functions\terms\sqrt\sqrt.md: Cannot find module '@codecademy/prettier-config' Any idea how to fix?

Did you try running yarn format content/cpp/concepts/math-functions/terms/isfinite/isfinite.md?

Dusch4593 avatar Sep 08 '22 18:09 Dusch4593

Yep

Hitarth-Kothari avatar Sep 08 '22 18:09 Hitarth-Kothari

Oh wait the slashes might have caused the error

Hitarth-Kothari avatar Sep 08 '22 18:09 Hitarth-Kothari

Oh wait the slashes might have caused the error

Yeah I was just noticing that. Are you working from a Windows computer?

Dusch4593 avatar Sep 08 '22 18:09 Dusch4593

Yes

Hitarth-Kothari avatar Sep 08 '22 18:09 Hitarth-Kothari

Yes

Gotcha. Yeah, let's try rerunning with the forward slash \ and see if that's what's causing the issue.

Dusch4593 avatar Sep 08 '22 18:09 Dusch4593

I ran the code with \ before My guess is I should have used /

Can't run the code rn but will try when I can

Hitarth-Kothari avatar Sep 08 '22 18:09 Hitarth-Kothari

Hey @Hitarth-Kothari just wanted to check and see if you had any questions or thoughts about the suggestions/comments that remain on this PR?

Dusch4593 avatar Sep 29 '22 17:09 Dusch4593

@Hitarth-Kothari... ... @SSwiniarski Anything left to add, change, or check before we approve and merge?

I happened to stumble on this PR and have some comments 💬

yangc95 avatar Oct 19 '22 21:10 yangc95

Hey @Hitarth-Kothari, did you need any assistance with the comments here?

yangc95 avatar Oct 25 '22 22:10 yangc95

👋 @Hitarth-Kothari You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!

github-actions[bot] avatar Oct 31 '22 16:10 github-actions[bot]

Congrats and thank you so much for contributing to Codecademy Docs, @Hitarth-Kothari! 🚀 🥳

The entry should now be live: https://www.codecademy.com/resources/docs/cpp/math-functions/isfinite

Screen Shot 2022-10-31 at 12 50 34 PM

Looking forward to your next contribution to Docs! 😄

Dusch4593 avatar Oct 31 '22 16:10 Dusch4593