docs icon indicating copy to clipboard operation
docs copied to clipboard

New Topic: Open Source

Open Dusch4593 opened this issue 2 years ago • 10 comments

Description

The following major work was done in this PR:

  • Added "Open Source" to the tags.md file.
  • Created a brand new "Open Source" topic file. (General concept entry removed)
  • Created a new Open Source concept called "Open Source Software".
    • Includes an extensive table listing different frameworks, languages, etc., that are OSS.
  • Migrated a lot of General concept entries into the Open Source topic**.
    • This is both to buff up the new Open Source topic and thin out/refocus the General topic.
    • **Also migrated entries for "Ruby on Rails" and "React Native" into Ruby and React topics, respectively.
  • Removed the General: Cloud Computing entry in anticipation of #930 being merged before this one.
    • This is to prevent potential merge conflicts.
  • Revised as many links via SourceGraph that would have broken otherwise. (Let me know if you find any more 😄)
  • Some moderate word-smithing.

Note: This is a huge pull request, so let's conduct at least four (4) reviews.

Type of Change

  • Adding new entries
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

Dusch4593 avatar Aug 29 '22 21:08 Dusch4593

@Dusch4593, I deleted the General: Cloud Computing entry in my PR. Is this going to cause a problem?

SSwiniarski avatar Aug 30 '22 16:08 SSwiniarski

@Dusch4593, I deleted the General: Cloud Computing entry in my PR. Is this going to cause a problem?

I don't think it should as long as our separate PRs didn't make separate/different changes in the same file(s).

Dusch4593 avatar Aug 30 '22 16:08 Dusch4593

@Dusch4593, it turns out that we're both making changes to the GraphQL entry.

SSwiniarski avatar Aug 30 '22 16:08 SSwiniarski

@Dusch4593, it turns out that we're both making changes to the GraphQL entry.

True. I wanted to make some changes as well as move the GraphQL entry inside the open source topic. To prevent conflicts, could we do the following:

  • In this PR, I'll incorporate the changes to the entry you made in your PR.
  • After I let you know I made those edits, could you remove the GraphQL entry from your PR altogether?

Dusch4593 avatar Aug 30 '22 16:08 Dusch4593

@Dusch4593, it turns out that we're both making changes to the GraphQL entry.

True. I wanted to make some changes as well as move the GraphQL entry inside the open source topic. To prevent conflicts, could we do the following:

  • In this PR, I'll incorporate the changes to the entry you made in your PR.
  • After I let you know I made those edits, could you remove the GraphQL entry from your PR altogether?

@Dusch4593 Sounds good.

SSwiniarski avatar Aug 30 '22 16:08 SSwiniarski

@SSwiniarski Ok, the changes were made 😄

Dusch4593 avatar Aug 30 '22 17:08 Dusch4593

@SSwiniarski Finished implementing your feedback. I had just one follow-up question to one of your comments/suggestions.

Dusch4593 avatar Aug 30 '22 17:08 Dusch4593

@Dusch4593, it turns out that we're both making changes to the GraphQL entry.

True. I wanted to make some changes as well as move the GraphQL entry inside the open source topic. To prevent conflicts, could we do the following:

  • In this PR, I'll incorporate the changes to the entry you made in your PR.
  • After I let you know I made those edits, could you remove the GraphQL entry from your PR altogether?

@Dusch4593 Sounds good.

@Dusch4593 I removed my edits to the GraphQL entry in my PR so we should avoid a conflict. The only changes I was making was bolding the first occurrence of "GraphQL" and linking the reference to "cloud services" to the new Cloud Computing topic.

SSwiniarski avatar Aug 31 '22 16:08 SSwiniarski

@HishamT Just finished implemented most of your feedback. Let me know if there's anything I missed. 😄

Dusch4593 avatar Sep 03 '22 12:09 Dusch4593

@HishamT Implemented your feedback.

cc: @KTom101 @yangc95 Let's get 1-2 more reviews for this PR before we merge 😄

Dusch4593 avatar Sep 14 '22 02:09 Dusch4593

@KTom101 Thank you very much for looking over these files and leaving feedback! I've implemented the new changes along with a few extra edits including reducing the width of the Linux Torvalds image by half (currently, the image is gigantic and obscures the opening text upon first page load).

Dusch4593 avatar Oct 04 '22 11:10 Dusch4593

Hey @KTom101 I believe I implemented all of your feedback in 9652fe7675a1830c167f32f04d44fdbd7bc6c858. I also deleted the git.md file under General since there is an entire Git topic already.

Dusch4593 avatar Oct 08 '22 14:10 Dusch4593

@KTom101 Just realized this morning that the table never got fixed 😅 But it should be fixed now!

Dusch4593 avatar Oct 10 '22 13:10 Dusch4593

@KTom101 Was there anything left to add, change, or check before merging?

Dusch4593 avatar Oct 11 '22 15:10 Dusch4593

@yangc95 Changes implemented 😄

Dusch4593 avatar Oct 14 '22 14:10 Dusch4593

@SSwiniarski @yangc95 @KTom101 @HishamT Thank you so much to everyone for their input and feedback for this new topic. This one was a long time coming. 😄 Live link for the new entries below:

Open Source (topic): https://www.codecademy.com/resources/docs/open-source Open Source Software (concept): https://www.codecademy.com/resources/docs/open-source/open-source-software

Dusch4593 avatar Oct 14 '22 18:10 Dusch4593