docs icon indicating copy to clipboard operation
docs copied to clipboard

New Entry: R CSV files + term entries

Open KTom101 opened this issue 2 years ago • 6 comments

New entry for R based on keyword list item 218

Description

Type of Change

  • Adding a new entry

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

KTom101 avatar Aug 14 '22 22:08 KTom101

@SSwiniarski So should the CSV entry link out to the data frame entry? Since when using the read.csv() and write.csv() functions it exports the content into a data frame.

KTom101 avatar Aug 18 '22 18:08 KTom101

@KTom101 That was my thought. CSV links out to data frame, and data frame has all these term entries.

SSwiniarski avatar Aug 19 '22 12:08 SSwiniarski

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 03 '22 22:09 CLAassistant

@SSwiniarski I added the changes you requested. I've also added a new data frame entry and have placed the term entries under it.

KTom101 avatar Sep 04 '22 00:09 KTom101

@SSwiniarski I've made the changes except for changing the "dataframes" folder to "data-frames" which I would have to do locally.

KTom101 avatar Sep 07 '22 18:09 KTom101

@Dusch4593 Most of the terms don't fit squarely under data frames.

colnames() works for matrices and data frames subset() works on vectors matrices and data frames nrow() and ncol() works on vectors, arrays, data frames, or matrices str() works on any object in R

That being said, I'm thinking str(), print(), getwd(), and setwd() can be under built-in-functions/built-in-functions.md

c() is used to create a vector (which is what we’re doing when we make each column in the data frame) so I think it may be more fitting to create an entry on vectors with c() in it.

The rest can stay as data frame terms (colnames(), subset(), nrow(), ncol()) and then can also be added under other concepts like matrices and arrays when they are hopefully added later on.

KTom101 avatar Sep 10 '22 20:09 KTom101

@yangc95 @Dusch4593 I've added lots of new updates based on your suggestions, thank you!! Let me know what other stuff needs to be changed.

KTom101 avatar Sep 29 '22 23:09 KTom101

@Dusch4593 Applied the suggestions!

KTom101 avatar Sep 30 '22 00:09 KTom101

@yangc95 You think this looks ok for merge?

Dusch4593 avatar Sep 30 '22 17:09 Dusch4593

@yangc95 Added the change let me know if there is anything else!

KTom101 avatar Oct 07 '22 00:10 KTom101

This PR looks good to merge! 🚀 I fixed some capitalization of "frame(s)" in data-frames.md (in c39af1bddb4dc780b7eabb2ea814133069e38212) after noticing a mix of "Data Frame(s)" and "data frame(s)".

Dusch4593 avatar Oct 07 '22 09:10 Dusch4593