docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon Codecademy

Created type error in python errors entry

Open sharkipelago opened this issue 2 years ago • 2 comments

Description

Added information and example of Type Error in Python Errors entry.

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

sharkipelago avatar Aug 07 '22 18:08 sharkipelago

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 07 '22 18:08 CLAassistant

@Dusch4593 I think I was able to fix the things you pointed out. Do I need to do something to request feedback again?

sharkipelago avatar Aug 10 '22 23:08 sharkipelago

@Dusch4593 Thanks for the feedback I corrected the last single-quote and the test passed locally, so hopefully it's all good. Also sorry I did not sync my branch with main before doing the latest correction. In general should I rebase or merge the main changes?

sharkipelago avatar Aug 13 '22 23:08 sharkipelago

@sharkipelago, No worries, I merged it when running the checks on your PR.

SSwiniarski avatar Aug 14 '22 13:08 SSwiniarski

@Dusch4593 Made the corrections :)

sharkipelago avatar Aug 17 '22 01:08 sharkipelago

Congratulations @sharkipelago, it looks like your changes were merged and are now live in the Python: Errors entry! 🎉 🎊

Quick question, though. Is your GitHub handle linked to your Codecademy profile? Although I see your changes, I don't see your profile credited near the top-right:

Screen Shot 2022-08-22 at 4 31 44 PM

Dusch4593 avatar Aug 22 '22 20:08 Dusch4593

@Dusch4593 Thanks for merging them! I think my github account is linked? I made this PR before linking it though, I'm not sure if that impacts anything. All I had to do was put my handle in the profile right? image

sharkipelago avatar Aug 22 '22 22:08 sharkipelago

@sharkipelago in addition to that, you may have to log out of your Codecademy account and re-login through your GitHub account. (see CONTRIBUTING.md for more details)

Screen Shot 2022-08-22 at 6 46 51 PM

After doing so, let's wait for a few minutes and check the Errors entry, again.

Dusch4593 avatar Aug 22 '22 22:08 Dusch4593