docs icon indicating copy to clipboard operation
docs copied to clipboard

New Entry and Terms: Java `StringBuilder`

Open SSwiniarski opened this issue 2 years ago • 4 comments

Description

From Target Keyword List

Type of Change

  • Adding a new entry

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

SSwiniarski avatar Aug 06 '22 15:08 SSwiniarski

@KTom101, I implemented your suggestions.

SSwiniarski avatar Aug 08 '22 11:08 SSwiniarski

@Dusch4593, I implemented all your suggestions. As for the nomenclature, I'd leave it be as "object" is referring to the SringBuilder object, and sequence is referring to the characters in the object.

SSwiniarski avatar Aug 13 '22 12:08 SSwiniarski

@Dusch4593, I implemented all your suggestions. As for the nomenclature, I'd leave it be as "object" is referring to the SringBuilder object, and sequence is referring to the characters in the object.

Gotcha! Thank you for the clarification 😄

Dusch4593 avatar Aug 13 '22 12:08 Dusch4593

Let's have one more review for this PR since it has over a dozen files. cc: @yangc95 @caupolicandiaz

Dusch4593 avatar Aug 13 '22 13:08 Dusch4593

@HishamT, I implemented your two suggestions.

SSwiniarski avatar Aug 20 '22 14:08 SSwiniarski

I think this is ready to merge. I made some small changes to the sentences preceding the output snippets in 30021ed143c505dc22ed7fa9927cb78c8e17818f.

cc: @SSwiniarski @KTom101 @HishamT

Dusch4593 avatar Aug 22 '22 17:08 Dusch4593