docs icon indicating copy to clipboard operation
docs copied to clipboard

[Edit] Python: Errors

Open Dusch4593 opened this issue 2 years ago • 8 comments

Type of Edit (select all that apply)

Add new content (definitions, codeblocks, etc.)

Description (optional)

Please add information about the TypeError to the existing entry (under the "Exception" section). Include 1-3 descriptive sentences and one (1) code snippet example.

Code of Conduct

  • [X] I agree to follow Codecademy Doc's Code of Conduct

For Maintainers

  • [X] Labels added
  • [x] Issue is assigned

Dusch4593 avatar Jul 26 '22 13:07 Dusch4593

Hi I'm new to contributing to open source, but think I could handle this task. Could I be assigned to this issue?

sharkipelago avatar Jul 27 '22 02:07 sharkipelago

@sharkipelago I will assign you this! You can take a look at our Contribution Guide here. Also, feel free to send us questions on this thread if you have any.

KTom101 avatar Aug 05 '22 18:08 KTom101

@KTom101 thank you! Also I think the issue is assigned task is still not checked off? Is there something I need to do in order to check it?

sharkipelago avatar Aug 05 '22 21:08 sharkipelago

@sharkipelago I've just checked it off. Thank you for that!

KTom101 avatar Aug 05 '22 21:08 KTom101

@KTom101 Hi! I've submitted a PR, but I think the Value Error information is wrong. For the Value Error, the example is correct but, I think the description describes a Type Error. So, I used that description and created a new example for the Type error information. Should I submit a new issue or PR to fix the Value Error description?

sharkipelago avatar Aug 07 '22 18:08 sharkipelago

@sharkipelago Thanks for pointing this out! You can edit the "Value Error" description in the same PR you just submitted.

KTom101 avatar Aug 07 '22 20:08 KTom101

@KTom101 I updated the PR is there anything else I need to do or just wait for feedback when it gets reviewed?

sharkipelago avatar Aug 07 '22 21:08 sharkipelago

@sharkipelago All you have to do is wait for feedback now. There are usually 2-3 rounds of review before merging.

KTom101 avatar Aug 07 '22 23:08 KTom101

This was addressed with PR 875

SSwiniarski avatar Oct 30 '22 13:10 SSwiniarski