docs icon indicating copy to clipboard operation
docs copied to clipboard

[Term Entry] Python NumPy - ndarray: max()

Open codecademy-docs opened this issue 2 months ago β€’ 21 comments

Reason/inspiration (optional)

We would like a new entry on the term max() under NumPy ndarray in Python. The entry should be in content/numpy/concepts/ndarray/terms/max/max.md

The entry should include the following:

  • A description of the term
  • A ##Syntax section that includes the syntax of the method and its details
  • An ##Example section that shows an example of the current entry.
  • An ## Codebyte section that have a compilable code inside it showing the current entry in use. Use ```codebyte/python to add compilable code.

Please refer to the term entry template, content standards and markdown style guide when working on the PR for this issue.

Entry Type (select all that apply)

New Term for Existing Concept Entry

Code of Conduct

  • [x] By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • [x] Labels added
  • [ ] Issue is assigned

codecademy-docs avatar Oct 27 '25 13:10 codecademy-docs

@codecademy-docs I would like to be assigned this issue, now that I submitted a PR at #7876!

ylevental avatar Oct 27 '25 15:10 ylevental

Hey @ylevental, could you pick up another PR please? Someone has raised a PR for this one already.

mamtawardhani avatar Oct 27 '25 15:10 mamtawardhani

Hey @Mohd-Abdul-Muqeet, please comment "CLAIM" on this issue. For future reference -> First comment on an issue -> Once the issue has been assigned to you -> then raise a PR.

mamtawardhani avatar Oct 27 '25 15:10 mamtawardhani

@mamtawardhani That makes things more confusing...

ylevental avatar Oct 27 '25 15:10 ylevental

@mamtawardhani Anyway, I just requested this one... https://github.com/Codecademy/docs/issues/7869

ylevental avatar Oct 27 '25 15:10 ylevental

I find that nobody is assigned to this can I get this issue assigned to me @codecademy-docs, I got to know about this through code academy's course Learn Git and GitHub. And am eager to contribute to this opensource documentation

7thmaniac avatar Nov 01 '25 21:11 7thmaniac

Hi @codecademy-docs and @mamtawardhani,

I would like to request assignment for this issue. I have previously contributed 4 merged PRs to this repository and would be happy to work on this NumPy ndarray .max() term entry.

Thank you for considering my request!

Priyanshjain10 avatar Nov 02 '25 14:11 Priyanshjain10

Hey @7thmaniac You’re assigned πŸŽ‰ In addition to the documents linked in the description, please also look at the Contribution Guide. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions before approval.

mamtawardhani avatar Nov 03 '25 05:11 mamtawardhani

Hey @Priyanshjain10, please take a look at other open issues. We'll also be uploading more issues in a day or two

mamtawardhani avatar Nov 03 '25 05:11 mamtawardhani

Thank you for the update, @mamtawardhani! I'll keep an eye on upcoming issues and look forward to contributing again soon.

Priyanshjain10 avatar Nov 03 '25 05:11 Priyanshjain10

Thank you very much for your consideration, and will definitely follow the guidelines. Thank you once again! @mamtawardhani

7thmaniac avatar Nov 03 '25 06:11 7thmaniac

Working on it just one more day I will submit a pull request for review

7thmaniac avatar Nov 08 '25 07:11 7thmaniac

Hey @7thmaniac, are you still working on this?

mamtawardhani avatar Nov 10 '25 06:11 mamtawardhani

Unassigned author due to inactivity

mamtawardhani avatar Nov 15 '25 10:11 mamtawardhani

Hi @mamtawardhani , I completed my 2 assigned issue so now you can assign this issue to me, I am happy to work on it and submit the pr in 1 to 2 days

Priyanshjain10 avatar Nov 15 '25 11:11 Priyanshjain10

Hi @mamtawardhani , I completed my 2 assigned issue so now you can assign this issue to me, I am happy to work on it and submit the pr in 1 to 2 days

Mamta already assigned the issue to herself. Can't believe this went through 15 comments already (excluding this one)! And the two people who were assigned, but never properly worked on this issue.

ylevental avatar Nov 15 '25 12:11 ylevental

Yes, I am done with it and editing the code according to the format suggested @mamtawardhani

7thmaniac avatar Nov 17 '25 01:11 7thmaniac

I want to submit a pull request now; just have a look at it!

7thmaniac avatar Nov 17 '25 01:11 7thmaniac

I want to submit a pull request now; just have a look at it!

Look where?

ylevental avatar Nov 17 '25 01:11 ylevental

Since I was unassigned I couldn't but if you want to you can check this link https://github.com/7thmaniac/docs

7thmaniac avatar Nov 17 '25 02:11 7thmaniac

Since I was unassigned I couldn't but if you want to you can check this link https://github.com/7thmaniac/docs

I see it now at #8005 but she already did it at #8002... Also, you have some formatting issues with how you did this pull request, in addition to not being formally assigned.

ylevental avatar Nov 18 '25 01:11 ylevental