docs icon indicating copy to clipboard operation
docs copied to clipboard

[Entry] HTML: `<s>` and `<del>` tags

Open not-a-ethan opened this issue 2 years ago • 9 comments

Reason/inspiration (optional)

The <s> is the strike-through element and the <del> element shows something is delegated but has semantic meaning.

s tag:

CC docs are good the best!

raw: <p>CC docs are <s>good</s> the best!</p>

del tag:

Make the base of the CC docs

raw: <p><del>Make the base of the CC docs</del></p>

Entry Type (select all that apply)

New Term for Existing Concept Entry

Code of Conduct

  • [X] I agree to follow Codecademy Doc's Code of Conduct

For Maintainers

  • [x] Labels added
  • [x] Issue is assigned

not-a-ethan avatar Apr 02 '22 20:04 not-a-ethan

Heya! Doesn't look like anyone's assigned to this one so mind if I work on it?

lyallstewart avatar Apr 07 '22 16:04 lyallstewart

@lyallstewart another SU contributing GREAT! Start working on this and a maintainer will assign you to this. Also, we got a category on the forums for the docs: https://discuss.codecademy.com/c/community/community-docs/2205.

not-a-ethan avatar Apr 07 '22 16:04 not-a-ethan

Haha yeah I saw that, that's what got me over here, been meaning to for a little while and only got round to it now 😄

lyallstewart avatar Apr 07 '22 16:04 lyallstewart

@lyallstewart You are assigned! 😄

Dusch4593 avatar Apr 07 '22 17:04 Dusch4593

Thank you!

lyallstewart avatar Apr 07 '22 18:04 lyallstewart

Hey @Dusch4593, given that these two tags are fairly similar do you think they should be a single entry referencing both tags or a separate entry for both?

It seems the latter would be more in line with what is already set up (and is what I've been working on for now given the important semantic differences as Ethan mentioned in the original post) but upon starting the starting article there seems to be a non-negligible amount of overlap so curious what you think

lyallstewart avatar Apr 14 '22 10:04 lyallstewart

@lyallstewart Put it in 1 file. The worst thing is we split it later.

not-a-ethan avatar Apr 14 '22 19:04 not-a-ethan

@lyallstewart Thank you again for taking on this issue and I humbly apologize for just now coming around to your prior comment/question.

given that these two tags are fairly similar do you think they should be a single entry referencing both tags or a separate entry for both?

Even if they are both similar, I would still recommend creating separate term entries for them under the HTML: Tags concept (one for <s> and one for <del>). Maybe include one sentence in each entry that points this out and links to the entry for the other, similar tag?

Dusch4593 avatar Apr 21 '22 15:04 Dusch4593

Hey @lyallstewart! 👋🏻

Just for clarity: Inside the html/concepts directory, all entries of this kind should be saved under /elements (not /tags), per a recent change.

Besides that, I also just wanted to check in to see if you had any questions regarding making a PR for this issue?

Dusch4593 avatar Jul 18 '22 15:07 Dusch4593

@lyallstewart, because there's been no activity on this for several weeks, I'm unassigning you so someone else can work on this. Feel free to claim another issue when you have time to work on it.

SSwiniarski avatar Oct 30 '22 13:10 SSwiniarski

can I work on this?

tanishq-singh-2407 avatar Nov 01 '22 17:11 tanishq-singh-2407

@tanishq-singh-2301 all yours!

yangc95 avatar Nov 01 '22 19:11 yangc95

Hi @Dusch4593, As you suggested, I'm here to ask you to assign this task to me.

Thank you!

Buono-Marco avatar Nov 10 '22 16:11 Buono-Marco

@Buono-Marco you've been assigned.

SSwiniarski avatar Nov 10 '22 17:11 SSwiniarski