[Concept Entry] PyTorch Tensors
Description
Created tensors.md within pytorch/concepts.
Issue Solved
Closes #4825
Type of Change
- Adding a new entry
Checklist
- [X] All writings are my own.
- [X] My entry follows the Codecademy Docs style guide.
- [X] My changes generate no new warnings.
- [X] I have performed a self-review of my own writing and code.
- [X] I have checked my entry and corrected any misspellings.
- [X] I have made corresponding changes to the documentation if needed.
- [X] I have confirmed my changes are not being pushed from my forked
mainbranch. - [X] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
- [X] I have linked any issues that are relevant to this PR in the
Issues Solvedsection.
@SaviDahegaonkar I have incorporated some of your suggestions and left my thoughts on the others.
@SaviDahegaonkar I have incorporated some of your suggestions and left my thoughts on the others.
Will check on it and let you know asap.
Hey @noahpgordon, sorry, but we have to close this PR as one is already present for tensor operations. I apologize for the mistake. You can get assigned for some other issue. Thank you!
@avdhoottt
I don't understand. This entry is a general overview of Tensors in PyTorch and is broader than the entry on Tensor Operations, which is presumably why these were created as two distinct issues. It covers many issues not covered on the operations entry, including creating and initializing tensors, tensor datatypes, and tensor shapes. It does not cover tensor operations in detail, in fact it actually links to the Tensor Operations page.
If the team wants only one page, why not merge the two, for example putting the content currently on Tensor Operations as a section of this page?
If there is going to be no page on Tensors generally but only Tensor Operations, where will the term entries like .size() and .view() go? It wouldn't make sense to put them all as term entries under Tensor Operations, since not all of them are operations on tensors. I'll also note that these term entries currently use a path file that uses this concept entry.
Edit: In fact, it seems a number of term entries were already approved and are awaiting this concept entry to appear on the main site, such as .ones(). It would make no sense to put this under Tensor Operations because it is a method for creating a tensor, not an operation on an existing tensor.
@noahpgordon, I understand what you are saying. I forgot to mention that I'll merge those two entries and give you credit as a co-author. We'll move the files under the Tensor operations concept entry. Thanks!!
@avdhoottt That's fine, but wouldn't it make more sense to rename the Tensor Operations entry to Tensors then? There will be material on the concept entry and term entries under it that are not about tensor operations.
I'd be happy to make a PR making these changes (i.e. merging the content on Tensor Operations onto here and keeping the term entries under Tensors).
@avdhoottt There are currently 8 term entries in the codebase that are invisible on the main site because this PR was closed, with the newest being added 3 days ago and the oldest 2 months ago. That's 8 people writing entries and 16 reviews, not including this PR. The original justification for closing this still makes no sense, since this page and the Tensor Operations page are clearly very distinct.
Looping in the other reviewers for this PR as well @SaviDahegaonkar @jrood
@noahpgordon My sincere apologies for the misunderstanding that happened here. We definitely do need this concept entry, parent to the term entries mentioned. I'll coordinate with the team to make sure we get this PR re-opened and merged.
👋 @noahpgordon You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!
🎉 Your contribution(s) can be seen here:
https://www.codecademy.com/resources/docs/pytorch/tensors https://github.com/Codecademy/docs/blob/main/documentation/catalog-content.md
Please note it may take a little while for changes to become visible. If you're appearing as anonymous and want to be credited, see here.