docs icon indicating copy to clipboard operation
docs copied to clipboard

[Concept Entry] MySQL built-in-functions

Open NelsonSanti opened this issue 1 year ago • 1 comments

Description

  • Added primary MySQL built-in functions
  • A built-in-functions.md was created with the respective concepts, syntax, and examples
  • All the code was tested in MySQL Workbench 8.0 CE software
  • Some name tables can sound strange. I had to improvise because things like "name" or "names" are special features
  • I tried to include a 'Database' subject but I was having issues afterwards trying to commit so I reset.

Issue Solved

  • Closes issue #4677

Type of Change

  • Adding a new entry

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [ ] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [ ] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

NelsonSanti avatar Jun 25 '24 23:06 NelsonSanti

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 25 '24 23:06 CLAassistant

Hey @cigar-galaxy82, could you please complete the review for this PR ASAP since it has been more than a month? Thank you 😃

mamtawardhani avatar Aug 06 '24 10:08 mamtawardhani

Hi, @NelsonSanti thank you for contributing to Codecademy docs, the entry is well written. I have suggested changes please modify

cigar-galaxy82 avatar Aug 07 '24 01:08 cigar-galaxy82

Hi, @NelsonSanti thank you for contributing to Codecademy docs, the entry is well written. I have suggested changes please modify

Hello, @cigar-galaxy82 , Thank you very much!

The modifications were done. Please check if everything is ok for you.

NelsonSanti avatar Aug 07 '24 17:08 NelsonSanti

Hi @NelsonSanti most of the changes look good, I have commented two changes are still required you can check them out and implement them in the whole entry

cigar-galaxy82 avatar Aug 08 '24 03:08 cigar-galaxy82

Hi @NelsonSanti most of the changes look good, I have commented two changes are still required you can check them out and implement them in the whole entry

I am sorry @cigar-galaxy82. I have "requested for review" by mistake while I was looking for the commented changes to do.

I think you are talking about this:

"Put this inside a pseudo-block and place a Syntax header above it". I thought I had done it. Maybe I am not understanding what is being asked. Can you please provide a visual example of it?

Thank very much

NelsonSanti avatar Aug 08 '24 14:08 NelsonSanti

Hi @NelsonSanti most of the changes look good, I have commented two changes are still required you can check them out and implement them in the whole entry

I am sorry @cigar-galaxy82. I have "requested for review" by mistake while I was looking for the commented changes to do.

I think you are talking about this:

"Put this inside a pseudo-block and place a Syntax header above it". I thought I had done it. Maybe I am not understanding what is being asked. Can you please provide a visual example of it?

Thank very much

Hi @cigar-galaxy82 , I think it is done. Please check the "put syntax code inside pseudo-block in the whole entry" commit. I apologize for this whole confusion. It is my first contribution. Thank you

NelsonSanti avatar Aug 09 '24 08:08 NelsonSanti

Hi @NelsonSanti no worries, I think somehow in your last push you have changed many files can you discard those changes

cigar-galaxy82 avatar Aug 09 '24 12:08 cigar-galaxy82

Hi @NelsonSanti no worries, I think somehow in your last push you have changed many files can you discard those changes

Hi @cigar-galaxy82,

It seems that nothing was changed and it is all good. I tried to revert this "verified" merged commit (I have no idea how does it appeared) but nothing happened because the changes were not done:

image

Then I tried to confirm it and there is no diff:

image

The other one was already reverted:

image

So I think it is all clean and the only changes are actually here:

image

Thank you

NelsonSanti avatar Aug 09 '24 16:08 NelsonSanti

Hi @NelsonSanti, I see that other files that are changed contain old information so I believe that when you pushed the new changes you forgot to git pull So files that are changed are not updated, so either you can git pull then push again. If this issue is not resolved you can create a new PR

cigar-galaxy82 avatar Aug 12 '24 05:08 cigar-galaxy82

Hi @NelsonSanti, I see that other files that are changed contain old information so I believe that when you pushed the new changes you forgot to git pull So files that are changed are not updated, so either you can git pull then push again. If this issue is not resolved you can create a new PR

Hello @cigar-galaxy82 ,

Thank you for your answer,

I followed your instructions making git pull first followed by git push:

git pull image image

git push image

Can you please check if everything is ok? If not, maybe I should save the md file content, delete this branch, and create another one.

NelsonSanti avatar Aug 12 '24 11:08 NelsonSanti

Hi @NelsonSanti the issue is still there so please close this PR and create a new one and request review by me

cigar-galaxy82 avatar Aug 12 '24 13:08 cigar-galaxy82