docs icon indicating copy to clipboard operation
docs copied to clipboard

[Term Entry] Python Plotly .scatter()

Open codecademy-docs opened this issue 10 months ago • 10 comments

Reason/inspiration (optional)

We would like a new term entry in the Data Visualization concept for Plotly: .scatter(). The entry should go in a new file under docs/content/plotly/concepts/express/terms/scatter/scatter.md

The entry should describe the term and how it is used. Also include:

  • An introductory paragraph that describes the concept
  • A 'Syntax' section that includes the syntax for the concept (if applicable)
  • An 'Example' section that shows the concept in use

Please refer to the entry templates, content standards, and markdown style guide when working on the PR for this issue.

Entry Type (select all that apply)

New Term for Existing Concept Entry

Code of Conduct

  • [X] By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • [X] Labels added
  • [x] Issue is assigned

codecademy-docs avatar Apr 22 '24 16:04 codecademy-docs

the plotly folder does not exist in https://github.com/Codecademy/docs/tree/main/content could you please update the correct location or let me know what is going wrong, and once that is done, I would like to be assigned this issue.

I found

docs/content/matplotlib/concepts/pyplot/terms/scatter/scatter.md

do you mean this?

KarinaNi avatar Apr 29 '24 09:04 KarinaNi

Hey @KarinaNi!

You can go ahead and create the directory named "plotly" as per the given path: docs/content/plotly/concepts/express/terms/scatter/scatter.md

@KarinaNi You're assigned. In addition to the documents linked in the description, please also look at our Contribution Guide if you haven't already. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions before approval.

Is this your first contribution to Codecademy Docs? If so, we're curious to know how you found out about contributing to Docs.

mamtawardhani avatar Apr 29 '24 17:04 mamtawardhani

Its my second contribution to Codecademy Docs I think. I have been an avid Codecademy user over the years, loved how they taught concepts with hands on immediate exercises. I did a course on Github on codecademy they asked me to do contributions here, I did two. I have recently been finding some open source to contribute to, so I came here to see if there are any issues I can help with. @mamtawardhani

KarinaNi avatar Apr 29 '24 19:04 KarinaNi

@KarinaNi That's good to hear! You can take up this issue!

mamtawardhani avatar Apr 30 '24 05:04 mamtawardhani

Okay so there are some tests that are failing in this PR. @mamtawardhani

format:verify
lint:md
I ran 
yarn test result: Tests: 4849 passed, 4849 total
yarn format: all: Ran successfully
yarn format:verify : Ran successfully
yarn lint: error message as below

The error message:

Oops! Something went wrong! :(

ESLint: 8.57.0

ESLint couldn't find the plugin "eslint-plugin-import".

(The package "eslint-plugin-import" was not found when loaded as a Node modulecs".)

It's likely that the plugin isn't installed correctly. Try reinstalling by run

    npm install eslint-plugin-import@latest --save-dev

The plugin "eslint-plugin-import" was referenced from the config file in ".esl

error Command failed with exit code 2.                                    rg/c
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.                                    s co
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.                                                                s co

How do I debug this? I went to https://www.npmjs.com/package/@codecademy/eslint-config?activeTab=versions the latest version is 8.0.0 how to resolve this issue, any steps would be highly appreciated

KarinaNi avatar May 05 '24 11:05 KarinaNi

Okay so there are some tests that are failing in this PR. @mamtawardhani

format:verify
lint:md
I ran 
yarn test result: Tests: 4849 passed, 4849 total
yarn format: all: Ran successfully
yarn format:verify : Ran successfully
yarn lint: error message as below

The error message:

Oops! Something went wrong! :(

ESLint: 8.57.0

ESLint couldn't find the plugin "eslint-plugin-import".

(The package "eslint-plugin-import" was not found when loaded as a Node modulecs".)

It's likely that the plugin isn't installed correctly. Try reinstalling by run

    npm install eslint-plugin-import@latest --save-dev

The plugin "eslint-plugin-import" was referenced from the config file in ".esl

error Command failed with exit code 2.                                    rg/c
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.                                    s co
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.                                                                s co

How do I debug this? I went to https://www.npmjs.com/package/@codecademy/eslint-config?activeTab=versions the latest version is 8.0.0 how to resolve this issue, any steps would be highly appreciated

KarinaNi avatar May 05 '24 11:05 KarinaNi

Hey @KarinaNi! It looks like you're encountering an ESLint error related to the eslint-plugin-import plugin not being found or installed correctly. Here's how you can fix it:

  1. Open your terminal or command prompt.
  2. Navigate to your project directory where ESLint is configured to run.
  3. Run the following command to reinstall the "eslint-plugin-import" plugin: npm install eslint-plugin-import@latest --save-dev

This command will install the latest version of the "eslint-plugin-import" plugin as a development dependency in your project.

  1. After the installation is complete, try running ESLint again to see if the issue has been resolved: eslint . --ext .js

Replace .js with the file extension(s) you want ESLint to check (e.g., .js, .jsx, .ts, .tsx).

If you're using Yarn instead of npm, you can use the following command to reinstall the plugin: yarn add eslint-plugin-import@latest --dev

After reinstalling the plugin, ESLint should be able to find and use the "eslint-plugin-import" plugin without any issues.

mamtawardhani avatar May 05 '24 18:05 mamtawardhani

Hi, I already ran the installation command yesterday and i got the following error

npm ERR! code ERESOLVE                                          g
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @codecademy/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/[email protected]
npm ERR!   node_modules/@eslint-community/eslint-utils
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from [email protected]
npm ERR!   peer eslint@"*" from @typescript-eslint/[email protected]
npm ERR!   node_modules/@typescript-eslint/experimental-utils
npm ERR!     @typescript-eslint/experimental-utils@"4.4.1" from @typescript-eslint/[email protected]
npm ERR!     node_modules/@codecademy/eslint-config/node_modules/@typescript-eslint/eslint-plugin
npm ERR!       @typescript-eslint/eslint-plugin@"4.4.1" from @codecademy/[email protected]
npm ERR!       node_modules/@codecademy/eslint-config
npm ERR!         dev @codecademy/eslint-config@"^3.1.0" from the root project
npm ERR!   5 more (eslint-config-prettier, eslint-plugin-react, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^6.5.1" from @codecademy/[email protected] ERR! node_modules/@codecademy/eslint-config
npm ERR!   dev @codecademy/eslint-config@"^3.1.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^6.5.1" from @codecademy/[email protected]
npm ERR!   node_modules/@codecademy/eslint-config
npm ERR!     dev @codecademy/eslint-config@"^3.1.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!

KarinaNi avatar May 06 '24 06:05 KarinaNi

Reinstalled yarn, upgraded yarn, added eslint through yarn, and yarn lint does not throw any errors in the command prompt. But there are the same errors that i posted. Any idea what I am missing?

Edit: The checks seem to run now. When can I see changes in the repository?

KarinaNi avatar May 06 '24 06:05 KarinaNi

@dakshdeepHERE @Sriparno08 Could you help solve the above issue, please?

mamtawardhani avatar May 06 '24 12:05 mamtawardhani

Hey @KarinaNi! Are you still working on this? Since it has been a month now, and this needs to be closed as soon as possible. Please do let me know 😃

mamtawardhani avatar May 31 '24 07:05 mamtawardhani

Hi! @mamtawardhani Please assist me. I have already submitted a pull request last month. I already pushed al the changes. Could you tell me where did I get stuck? image

KarinaNi avatar May 31 '24 08:05 KarinaNi

Checking this @KarinaNi

mamtawardhani avatar May 31 '24 11:05 mamtawardhani

@KarinaNi which of your local branches contains this entry file? image

dakshdeepHERE avatar May 31 '24 15:05 dakshdeepHERE

@KarinaNi I will suggest u to take the entry outside of the docs folder once create a new branch add that file on this path docs/content/plotly/concepts/express/terms/scatter/scatter.md and try creating the PR again? Also can u please give me the steps u are following to create the PR.

dakshdeepHERE avatar May 31 '24 15:05 dakshdeepHERE

@KarinaNi any updates?

dakshdeepHERE avatar Jun 01 '24 05:06 dakshdeepHERE

Give me an hour I'll reply sorry about the delay

On Sat, Jun 1, 2024, 8:28 AM Daksha Deep @.***> wrote:

@KarinaNi https://github.com/KarinaNi any updates?

— Reply to this email directly, view it on GitHub https://github.com/Codecademy/docs/issues/4558#issuecomment-2143303616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHV4BJMLY2CUQHU4OHGSDYDZFFLZXAVCNFSM6AAAAABGTDNEJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGMYDGNRRGY . You are receiving this because you were mentioned.Message ID: @.***>

KarinaNi avatar Jun 01 '24 09:06 KarinaNi

so my steps were i had already forked the repo because i had contributed before, i cloned it made changes committed, and pushed it. And created a pull request filled all forms and I believe i was done. Then there were some checks that weren't working then somehow it ended up passing and yes that was my steps sorry for the delay @dakshdeepHERE

KarinaNi avatar Jun 01 '24 10:06 KarinaNi

I plan on contributing to the docs again, so before i work on the next issue, could you please tell me any steps i should change so this issue doesn't happen?

KarinaNi avatar Jun 03 '24 11:06 KarinaNi

Hey @KarinaNi, I guess you have created the PR directly on the main docs, instead of the forked one on your side, could you please check that and raise a PR for this as soon as possible? Please take a look at the Contribution Guide once again

mamtawardhani avatar Jun 12 '24 06:06 mamtawardhani

okay I try to create a PR from my side right? the forked one. i will try to do it.

KarinaNi avatar Jun 12 '24 07:06 KarinaNi

🌸 Thanks for closing this Issue! Please head over to the Docs Forum if you have any questions about Docs, or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

github-actions[bot] avatar Jun 19 '24 15:06 github-actions[bot]