docs icon indicating copy to clipboard operation
docs copied to clipboard

New term entry on the built in function for Numpy named 'svd'

Open doroodianMostafa opened this issue 1 year ago • 4 comments

new term entry on the built in function for Numpy named SVD(Singular Value Decomposition) under svd.md

Description

This is a new term entry on the built-in-functions term for [Numpy]: Singular Value Decomposition. The is in a new file under docs/content/numpy/concepts/built-in-functions/terms/svd/svd.md

I'd like to acknowledge that the following link served as my source of motivation or inspiration for the provided example: numpy.linalg.svd() documentation.

Issue Solved

Closes #4479

Type of Change

  • Adding a new entry

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

doroodianMostafa avatar Apr 19 '24 08:04 doroodianMostafa

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 19 '24 08:04 CLAassistant

Thank you for your comment, I tried to redo it through the provided link, I hope this time it's addressed. Otherwise I do appreciate further instructions.

Besides I do not understand why it's mentioned that there are two committers, since my account is doroodianMostafa.

doroodianMostafa avatar Apr 19 '24 10:04 doroodianMostafa

@doroodianMostafa it appears that you've submitted this PR using two accounts (The other one is @doroodian ). Therefore, please sign this CLA with both accounts or close this and resubmit a new PR using only one account.

mamtawardhani avatar Apr 20 '24 06:04 mamtawardhani

Thanks for clarification, I found it easier to sign the CLA with other account as well, since I have no idea how I submitted with two accounts. I hope now the matter is addressed.


From: mamtawardhani @.> Sent: Saturday, April 20, 2024 8:44 To: Codecademy/docs @.> Cc: Doroodian, M. (Mostafa) @.>; Mention @.> Subject: Re: [Codecademy/docs] New term entry on the built in function for Numpy named 'svd' (PR #4547)

@doroodianMostafahttps://github.com/doroodianMostafa it appears that you've submitted this PR using two accounts (The other one is @doroodianhttps://github.com/doroodian ). Therefore, please sign this CLA with both accounts or close this and resubmit a new PR using only one account.

— Reply to this email directly, view it on GitHubhttps://github.com/Codecademy/docs/pull/4547#issuecomment-2067578840, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ3XQOCWXP76KFJ7NVWRM6LY6IFERAVCNFSM6AAAAABGOY52GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGU3TQOBUGA. You are receiving this because you were mentioned.Message ID: @.***>

doroodianMostafa avatar Apr 20 '24 09:04 doroodianMostafa

Hi @letsbuildanything, Thanks for taking responsibility for the second review. Looking forward to hear your feedbacks. Thank you.

doroodianMostafa avatar May 13 '24 09:05 doroodianMostafa

Hi @letsbuildanything @mamtawardhani ,

I'm following up on my git commit, with number #4547. I am really excited to get this task done, and through it learn from you, however It's been three weeks since I heard back from you.

I understand you might be busy, but I wanted to check if there's anything I can do to help expedite the review process. Are there any additional details I can provide, or would you like me to address any specific questions?

Thanks, Mostafa

doroodianMostafa avatar May 22 '24 11:05 doroodianMostafa

@letsbuildanything as I can notice that you've taken up the second review, could you please finish the reviewing of this entry at your earliest convenience?

@doroodianMostafa we'll finish the review and merge it asap, thanks for the update and sorry for the inconvenience caused.

mamtawardhani avatar May 22 '24 11:05 mamtawardhani

Hey @doroodianMostafa, It looks like your recent commit has reverted the changes I made in this commit.

letsbuildanything avatar May 25 '24 18:05 letsbuildanything

Dear @letsbuildanything , Sorry for the inconvenience. I just saw that my recent changes discarded your changes. It seems I made changes before updating my local version, which led to the return of your previous comments. However, I've just applied your changes in a new commit. This should resolve the issue. Let me know if there's anything else I can do to help.

doroodianMostafa avatar May 25 '24 21:05 doroodianMostafa

👋 @doroodianMostafa You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/numpy/built-in-functions/svd

Please note it may take a little while for changes to become visible. If you're appearing as anonymous and want to be credited, see here.

github-actions[bot] avatar May 26 '24 08:05 github-actions[bot]