docs icon indicating copy to clipboard operation
docs copied to clipboard

forEach.md for ArrayList in Java

Open hakdo99 opened this issue 1 year ago • 2 comments

Description

Added file forEach.md to explain the .forEach() method as a new term entry for ArrayList in Java. The markdown file is placed under the file path content/java/concepts/array-list/terms/forEach/forEach.md

Issue Solved

Closes #4338

Type of Change

  • Adding a new entry

Checklist

  • [x ] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [x ] My changes generate no new warnings.
  • [ x] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [ x] I have made corresponding changes to the documentation if needed.
  • [x ] I have confirmed my changes are not being pushed from my forked main branch.
  • [x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ x] I have linked any issues that are relevant to this PR in the Issues Solved section.

hakdo99 avatar Feb 14 '24 10:02 hakdo99

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 14 '24 10:02 CLAassistant

@ishg-153 Hi, I have made the changes to forEach.md and pushed it to the same branch. Let me know if you can see it. Thanks!

hakdo99 avatar Feb 29 '24 03:02 hakdo99

Hey @hakdo99 Your changes aren't visible on this branch. Can you please check again and push to this exact branch of your fork.

ishg-153 avatar Mar 10 '24 13:03 ishg-153

@ishg-153 Yes I did push to the exact same branch. I edited the file manually based on your suggestions above, because at that time I wasn't aware I could just commit the suggestions from here. In this commit, you can see the changes I made based on your review. This modified version is also reflected here, in the path to this forEach.md file under the hakdo branch, which is the same branch I created to work on this issue

hakdo99 avatar Mar 14 '24 17:03 hakdo99

@hakdo99 The branch this PR corresponds to is hakdo. But you have made changes to main branch on your fork, which we can't use because it is required that you make the PR on a separate branch.

So I request you to make the same changes to this branch. And as you mentioned you can also directly make the changes in this PR on GitHub instead of using your local file.

ishg-153 avatar Mar 15 '24 14:03 ishg-153

@hakdo99 it's been 2 weeks, are you still working on this PR.

Note: If you don't respond within a week, this PR will be closed.

ishg-153 avatar Apr 01 '24 05:04 ishg-153

@ishg-153 Sorry I only have a chance to look back at this now. I think there may be some other reason why my last changes aren't shown in the hakdo branch on your end, not because I made them on the main branch of my fork, since I never did. I'm seeing that the forEach.md file is not even in the main branch, because I've never done anything involving this forEach issue on the main branch in the first place. Right now I can't directly make the changes in this PR on GitHub by committing your suggestions anymore. That button is greyed out for me and it says because the suggestions are outdated. That is because I have already changed the original file on this hakdo branch based on your suggestion. Also, on my end, I'm still seeing my changes reflected on this file on the hakdo branch. I really want to solve this problem but I'm not sure how right now. I'm sure that I committed to the right branch that is hakdo and not the main branch. And that right now on Github, I'm still seeing this forEach.md file, with my new changes, when I look at the hakdo branch, and when I switch to the main branch, it says file not found because this file never exists on the main branch. Could you please take a look again and see if there could be another reason why my changes aren't shown on this hakdo branch on your end? Sorry for this inconvenience.

hakdo99 avatar Apr 01 '24 06:04 hakdo99

@hakdo Can you please take a screenshot of the entry with all the suggested changes made as you see it and send here?

ishg-153 avatar Apr 01 '24 06:04 ishg-153

This is how the entry looks on my end: forEach commit.pdf For your reference, the link to that commit is here: https://github.com/Codecademy/docs/commit/ad4cbb28fa3a27cf204e351251a7e1cc34bf4dcc

Also, this is to show that my forEach.md file is not on the main branch: image But the file can be seen when switched to the hakdo branch: image For the full page, that screenshot is taken from this link: https://github.com/hakdo99/codeacademy-docs/blob/hakdo/content/java/concepts/array-list/terms/forEach/forEach.md . If you read the content of this file and compare it to the changes you suggested, you may notice that those changes have all been reflected here.

hakdo99 avatar Apr 01 '24 09:04 hakdo99

@ishg-153 Okay then that's all good now haha!

hakdo99 avatar Apr 09 '24 17:04 hakdo99

👋 @hakdo99 You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/java/array-list/forEach

Please note it may take a little while for changes to become visible. If you're appearing as anonymous and want to be credited, see here.

github-actions[bot] avatar Apr 11 '24 07:04 github-actions[bot]