docs icon indicating copy to clipboard operation
docs copied to clipboard

added pngs and a new example to further explain the matter

Open RAFIMIKI opened this issue 1 year ago • 6 comments

Description

Issue Solved

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Changes

  • Changed the 'top' typo from the css blocks to the correct 'right'
  • added example 3 to further explain how to use it
  • added PNGS to visualize everything

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

RAFIMIKI avatar Jan 29 '24 00:01 RAFIMIKI

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 29 '24 00:01 CLAassistant

I signed the CLA and put the pngs in the media folder

will be finished very soon

RAFIMIKI avatar Jan 31 '24 12:01 RAFIMIKI

@RAFIMIKI Are you still working on the requested change?

ishg-153 avatar Feb 06 '24 18:02 ishg-153

@RAFIMIKI It's been 2 weeks. If you don't respond with an update or push the changes within the next week. This PR will be closed.

ishg-153 avatar Feb 15 '24 17:02 ishg-153

Sorry for not responding I’ve been busy, I did a push request and it was accepted, thought that it was done, what’s left to do?

RAFIMIKI avatar Feb 15 '24 17:02 RAFIMIKI

Sorry for not responding I’ve been busy, I did a push request and it was accepted, thought that it was done, what’s left to do?

The images aren't reflected in the media folder, please take a look at my previous comment one more time to get a better understanding

ishg-153 avatar Feb 24 '24 18:02 ishg-153

@RAFIMIKI It's been two weeks are you still working on this PR.

ishg-153 avatar Mar 10 '24 13:03 ishg-153

@RAFIMIKI Due to your lack of response this PR is being closed and the corresponding issue unassigned.

ishg-153 avatar Mar 15 '24 11:03 ishg-153