docs icon indicating copy to clipboard operation
docs copied to clipboard

Add bubble sort term to general/concepts/algorithm

Open JorisBolwerk opened this issue 1 year ago • 4 comments

Description

Added Bubble Sort to the docs by explaining it and giving a code example in java

Issue Solved

#4147 [Entry] Algorithms: Adding Bubble Sort

Type of Change

  • Adding a new entry

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

JorisBolwerk avatar Jan 27 '24 23:01 JorisBolwerk

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 27 '24 23:01 CLAassistant

Thank you for your feedback, @avdhoottt ! pushed the new version in which all suggestions are implemented. In the example I use media from Wikimedia and made it to comply to the following:

You are free: to share – to copy, distribute and transmit the work to remix – to adapt the work Under the following conditions: attribution – You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use. share alike – If you remix, transform, or build upon the material, you must distribute your contributions under the same or compatible license as the original.

JorisBolwerk avatar Jan 30 '24 15:01 JorisBolwerk

Hey @JorisBolwerk Can you make the suggested changes?

avdhoottt avatar Feb 29 '24 16:02 avdhoottt

Hey @JorisBolwerk Can you make the suggested changes?

Hey @avdhoottt, can you please list you suggestions that have not been implemented yet? Thanks

JorisBolwerk avatar Mar 02 '24 13:03 JorisBolwerk

Hey @JorisBolwerk Can you make the suggested changes?

Hey @avdhoottt, can you please list you suggestions that have not been implemented yet? Thanks

You have not uncommitted the yarn.lock file. Can you do that?

avdhoottt avatar Mar 05 '24 17:03 avdhoottt

Hi @avdhoottt, I hope I solved the issue this way. Please get back to me if there are still problems. Thanks

JorisBolwerk avatar Mar 05 '24 20:03 JorisBolwerk

Hey @avdhoottt, I think the required changes are done for this PR, could you check and confirm? Thanks!

mamtawardhani avatar Jun 05 '24 10:06 mamtawardhani

@avdhoottt I wanted to update you regarding this PR, following the instructions from Rashi, I conducted the second review, which involved making minor adjustments with the tags and improving the overall appearance of the content.

After thorough examination, I found that the author has successfully implemented all the changes requested by you. Consequently, based on my review, I confirm that the PR is free of any issues. Therefore, I'm proceeding with the merge. Thank you 😃

mamtawardhani avatar Jun 19 '24 11:06 mamtawardhani

👋 @JorisBolwerk You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/general/algorithm/bubble-sort

Please note it may take a little while for changes to become visible. If you're appearing as anonymous and want to be credited, see here.

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]