docs icon indicating copy to clipboard operation
docs copied to clipboard

[Edit] HTML Add Media: Links

Open codecademy-docs opened this issue 2 years ago • 34 comments

Type of Edit (select all that apply)

Add new content (definitions, codeblocks, etc.)

Description (optional)

We would like to make an edit for HTML Links. The entry should go in the existing file in docs/content/html/concepts/links/links.md

Please refer to the concept entry templates, content standards, and markdown style guide when working on the PR for this issue.

Bear in mind:

  1. Add supplemental media (preferred .png or .gif, <1MB).
  2. Media should accurately represent the existing content and fit in-line.

Code of Conduct

  • [X] By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • [x] Labels added
  • [x] Issue is assigned

codecademy-docs avatar Sep 11 '23 15:09 codecademy-docs

I would like to be assigned please

maxx-l avatar Sep 12 '23 09:09 maxx-l

@maxx-l You're assigned 🎉 In addition to the documents linked in the description, please also take a look at our Contribution Guide. After creating a PR, the maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approval.

Is this your first contribution to Codecademy Docs? If so, we're curious to know how you found out about contributing to Docs.

KTom101 avatar Sep 13 '23 00:09 KTom101

Thank @KTom101 , yes it's my first contribution. It's the Git/Github course that brought me here

maxx-l avatar Sep 14 '23 06:09 maxx-l

@maxx-l I unassigned you because you closed your PR.

SSwiniarski avatar Oct 21 '23 12:10 SSwiniarski

@codecademy-docs I wanted to taking this issue on, kindly let me to.

KNBahir avatar Oct 21 '23 13:10 KNBahir

@codecademy-docs I'm also interested to take on this issue, @KNBahir maybe we can do it together?

Kosyenka avatar Oct 21 '23 15:10 Kosyenka

I am interested as well, if available...

DakuwoN avatar Oct 22 '23 03:10 DakuwoN

@KNBahir You're assigned! You can check out the Contribution Guide for additional information on contributing. See Content Standards for an overview of styling tips that the Style Guide covers in detail. After creating a PR, maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approving.

In addition, please head over to the Docs Forum if you have any questions about Docs or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

SSwiniarski avatar Oct 22 '23 13:10 SSwiniarski

@Kosyenka, @DakuwoN, @KNBahir claimed this one first.

SSwiniarski avatar Oct 22 '23 13:10 SSwiniarski

@KNBahir It's been two weeks. Are you still working on this issue? Note in another week this will be unassigned due to inactivity.

SSwiniarski avatar Nov 04 '23 14:11 SSwiniarski

@KNBahir this is being unassigned due to inactivity.

SSwiniarski avatar Nov 12 '23 16:11 SSwiniarski

@SSwiniarski I am willing to tackle this issue 🙏

DakuwoN avatar Nov 12 '23 17:11 DakuwoN

@DakuwoN, You're assigned.

SSwiniarski avatar Nov 13 '23 12:11 SSwiniarski

I am not exactly sure what needs done here?

DakuwoN avatar Nov 21 '23 02:11 DakuwoN

@DakuwoN The issue is to create an image that illustrates part of the existing entry and add it to the entry.

SSwiniarski avatar Nov 21 '23 12:11 SSwiniarski

@DakuwoN It's been two weeks. Are you still working on this entry? Note in another week this will be unassigned due to inactivity.

SSwiniarski avatar Nov 26 '23 17:11 SSwiniarski

Sorry I took a break for Thanksgiving. I will resume and finish tomorrow

DakuwoN avatar Nov 28 '23 03:11 DakuwoN

I am sorry, I got tied up with school, you can un assign me as I won't have time this week.

DakuwoN avatar Nov 29 '23 02:11 DakuwoN

I would like to claim this issue as my first contribution. I am attempting this as part of the GIt/GitHub lesson on Codecademy. Many thanks.

nsLittle avatar Nov 29 '23 15:11 nsLittle

@nsLittle You're assigned! You can check out the Contribution Guide for additional information on contributing. See Content Standards for an overview of styling tips that the Style Guide covers in detail. After creating a PR, maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approving.

In addition, please head over to the Docs Forum if you have any questions about Docs or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

SSwiniarski avatar Nov 29 '23 20:11 SSwiniarski

@KTom101 and @SSwiniarski Hi I'd like to claim this issue as part of the GitHub course, thank you in advance.

F-Viedge avatar Jan 24 '24 20:01 F-Viedge

@F-Viedge This issue is already assigned and has a PR open for it.

SSwiniarski avatar Jan 25 '24 12:01 SSwiniarski

@SSwiniarski Okay thanks for getting back to me I'll try find another...

F-Viedge avatar Jan 25 '24 12:01 F-Viedge

Hi I'm still in the woods for a issue to work on as part of the course could you please notify me when this becomes available?

F-Viedge avatar Jan 26 '24 14:01 F-Viedge

@F-Viedge https://github.com/F-Viedge, here is what I did:

  1. Go to Codecademy's "claim an issue" link https://www.codecademy.com/resources/docs/contribution-guide/claiming-an-issue .
  2. Go to GitHub "doc repository" link https://github.com/Codecademy/docs/issues part way down the page on #1.
  3. Go to the "issues" tab https://github.com/Codecademy/docs/issues (as mentioned on the page in link #1).
  4. See image #1 below. Notice the colored tags on each line item. Look for issues with the purple "good first issue." Now make sure the issue does NOT have a red "claimed" tag. Many of the issues applicable to us newbies are already claimed, but they are there!
  5. See image #2 below. Notice the first and third line. It has the purple "good first issue" and NO "claimed" tag. You can claim either of those tags if they pique your interest. Otherwise, there should be more pickings down the line.

@SSwiniarski https://github.com/SSwiniarski, I am having issues with (a) inserting an image into a Markdown document (the problem i have is an issue related to the path i have to the image), and (b) I am not sufficiently learn-ed in git commands, and I need to stop panicking and go through the whole process again. Is there someone who can help me check the path? I've Google'd, ChaptGPT'd, but I really need a human to ensure I have the path correct. Thank you!

[image: iamge1.png]

[image: image2.png]

On Fri, Jan 26, 2024 at 9:19 AM Frederick Viedge @.***> wrote:

Hi I'm still in the woods for a issue to work on as part of the course could you please notify me when this becomes available?

— Reply to this email directly, view it on GitHub https://github.com/Codecademy/docs/issues/3231#issuecomment-1912141828, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCOZZRV7SO7FAZVBJJFPSBDYQO3NVAVCNFSM6AAAAAA4TPYFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGE2DCOBSHA . You are receiving this because you were assigned.Message ID: @.***>

nsLittle avatar Jan 27 '24 11:01 nsLittle

@nsLittle Instructions on how to add an image in an entry are in the style guide here.

The path will be to the Docs repository media folder.

SSwiniarski avatar Jan 27 '24 13:01 SSwiniarski

@nsLittle you closed your PR, does that mean you're no longer working on this issue?

SSwiniarski avatar Jan 28 '24 13:01 SSwiniarski

No, oops. I thought I asked for a pull request for you to look at my update. sigh big apologies. Can I still have the issue?

On Sun, Jan 28, 2024 at 8:02 AM SSwiniarski @.***> wrote:

@nsLittle https://github.com/nsLittle you closed your PR, does that mean you're no longer working on this issue?

— Reply to this email directly, view it on GitHub https://github.com/Codecademy/docs/issues/3231#issuecomment-1913589221, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCOZZRSJABWUFR7EDFUSWQ3YQZD5DAVCNFSM6AAAAAA4TPYFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU4DSMRSGE . You are receiving this because you were mentioned.Message ID: @.***>

nsLittle avatar Jan 28 '24 13:01 nsLittle

@nsLittle it's ok. The new PR just wasn't linked to the issue so I didn't see it.

SSwiniarski avatar Jan 29 '24 12:01 SSwiniarski

@nsLittle sorry for the late reply thanks for guidance on finding issues, I feel I'm getting a bit sidetracked from the codecademy course I'm busy with and don't yet have enough knowledge to tackle the current issues available...I still think this one is something I could add to.

When you're done with it if you guys could let me have a go at it I'd really appreciate it. Thank you @SSwiniarski

F-Viedge avatar Jan 30 '24 07:01 F-Viedge