docs icon indicating copy to clipboard operation
docs copied to clipboard

[New Entry] C: data types

Open Nessvah opened this issue 2 years ago • 3 comments

Description

Closes #886

Type of Change

  • Adding a new entry

Checklist

  • [X] All writings are my own.
  • [X] My entry follows the Codecademy Docs style guide.
  • [X] My changes generate no new warnings.
  • [X] I have performed a self-review of my own writing and code.
  • [X] I have checked my entry and corrected any misspellings.
  • [X] I have made corresponding changes to the documentation if needed.
  • [X] I have confirmed my changes are not being pushed from my forked main branch.
  • [X] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [X] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

Nessvah avatar Sep 13 '22 09:09 Nessvah

@Nessvah I finished the first review and left some comments.

thank you. I'll make the changes as soon as possible. I was considering including how to make the conversions and talk about the signed and unsigned types, what do you think?

Nessvah avatar Sep 15 '22 17:09 Nessvah

@Nessvah I finished the first review and left some comments.

thank you. I'll make the changes as soon as possible. I was considering including how to make the conversions and talk about the signed and unsigned types, what do you think?

@Nessvah, both would be good additions if they're relatively brief. We don't want Docs entries to become overlong.

SSwiniarski avatar Sep 16 '22 11:09 SSwiniarski

@Nessvah I finished the first review and left some comments.

thank you. I'll make the changes as soon as possible. I was considering including how to make the conversions and talk about the signed and unsigned types, what do you think?

@Nessvah, both would be good additions if they're relatively brief. We don't want Docs entries to become overlong.

@SSwiniarski Let me know if after this review there's still space to improve and maybe add those two topics.

Nessvah avatar Sep 21 '22 16:09 Nessvah

@Nessvah Finished with my review and left some comments/suggestions. The content in this entry seems to only cover primitive data types. But we should also include information about these other classifications:

Great suggestion! I'll work on that.

Nessvah avatar Sep 30 '22 02:09 Nessvah

@Nessvah Just a few more comments/suggestions from me smile

😃 Awesome! I'll take a look at it later today.

Nessvah avatar Oct 24 '22 16:10 Nessvah

👋 @Nessvah You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!

github-actions[bot] avatar Oct 31 '22 18:10 github-actions[bot]

Congrats and thank you so much for another awesome contribution to Codecademy Docs, @Nessvah! 🚀

The entry should now be live: https://www.codecademy.com/resources/docs/c/data-types

Screen Shot 2022-10-31 at 2 34 41 PM

Looking forward to your next contribution! 😄

Dusch4593 avatar Oct 31 '22 18:10 Dusch4593

@Dusch4593 Thank you so much! It's always a pleasure to help and learn with you guys 😄 👍🏻

Nessvah avatar Nov 01 '22 06:11 Nessvah