syllabus icon indicating copy to clipboard operation
syllabus copied to clipboard

Published 20 hours ago • verified publisher icon CodeYourFuture

Style guide violation, please update

Open SallyMcGrath opened this issue 2 years ago • 4 comments

https://github.com/CodeYourFuture/syllabus/blob/02da63dbe1a20f8df0559074f4dac810e8af62a8/docs/workshops/js-testing-workshop.md?plain=1#L54

Improper use of var

https://syllabus.codeyourfuture.io/guides/code-style-guide

Please update to follow our own advice

SallyMcGrath avatar Jan 14 '23 07:01 SallyMcGrath

what can we use instead of var?

MohitBansal321 avatar Jan 14 '23 18:01 MohitBansal321

what can we use instead of var?

let

SallyMcGrath avatar Jan 14 '23 19:01 SallyMcGrath

i created a pull request

MohitBansal321 avatar Jan 15 '23 06:01 MohitBansal321

I changed all var to let according to style guide @SallyMcGrath please let me know how is it

MohitBansal321 avatar Jan 17 '23 09:01 MohitBansal321