curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Tidy up emojis

Open SallyMcGrath opened this issue 1 year ago • 6 comments

A poem by Sally aged 41 and three quarters

We have emojis used really inconsistently. Each block has an emoji param, but Instead of showing that in the front end, it's often skipped For this reason, I think, users have hardcoded emojis into titles But not all users...

So sometimes there are emojis in titles and sometimes not And sometimes the emojis in the side menu on the prep view are there and sometimes not. So it looks a mess And it breaks scanlines

I think we always want an emoji to identify a block And this emoji should be consistent

But this is a really boring job! It means going through each block and moving the hardcoded emoji into the emoji param And then calling that emoji in these contexts:

local block titles
table of contents titles
overview page titles
probably search results titles

OK maybe it's not a poem, but it's still something worth doing

SallyMcGrath avatar Sep 22 '24 08:09 SallyMcGrath

I would take any number of PRs on this ticket -- if you just want to do 1 misplaced emoji that would be helpful. Many hands!

SallyMcGrath avatar Sep 27 '24 09:09 SallyMcGrath

Before I continue, can you have a look if I am doing this correctly @SallyMcGrath

fcaroline2020 avatar Sep 28 '24 12:09 fcaroline2020

Fab, thank you!

SallyMcGrath avatar Sep 28 '24 16:09 SallyMcGrath

Is this issue still open?

tharikashree avatar Oct 06 '24 23:10 tharikashree

@tharikashree Yep there are hundreds to do. If you want to just do a section, like @fcaroline2020 just did, drop a comment or make a new ticket saying what emojis you are going to work on and link back to this ticket #984 🙏

SallyMcGrath avatar Oct 07 '24 10:10 SallyMcGrath

I am so sorry for my ignorance but I don't know how to work with hugo and Netlify CMS

tharikashree avatar Oct 07 '24 11:10 tharikashree

We think it's a good idea to do #867 at the same time.

40thieves avatar Oct 22 '24 17:10 40thieves

@SallyMcGrath I see https://github.com/CodeYourFuture/curriculum/issues/867 is completed. Just want to check if there is anything I need to be mindful of when replacing emojis?

fcaroline2020 avatar Nov 07 '24 16:11 fcaroline2020