curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Consider excluding dependabot PRs from the Code Review block

Open 40thieves opened this issue 2 years ago • 0 comments

Which module(s) and week(s) does this change affect? Module(s): N/A Week(s): N/A

What is the work that needs to be done?

Code Review blocks currently show all PRs on the linked repo, including PRs such as dependabot PRs:

Code review block showing dependabot PR

I think the intention of these blocks is to get volunteer eyes on trainee coursework, hopefully so that they get some feedback. Do we want to try filter this list a bit so that it's more focused on coursework review? We could filter out PRs with the dependency label (as dependabot always adds that). But on the other hand, perhaps we want volunteers to see & review those PRs?

It would also be harder to filter out non-coursework PRs that don't come from dependabot - i.e. PRs by volunteers that are fixing changing the coursework.

Why is this work important to do?

Focusing volunteer attention on coursework PRs seems like a good thing to do. And they may not have the context on other PRs to be able to quickly review them.

Additional context

Who might need to know about this change?

@CodeYourFuture/global-syllabus

40thieves avatar Nov 10 '23 23:11 40thieves