curriculum
curriculum copied to clipboard
Pull requests open in new tab
What does this change?
When clicking on a pull request I lose the ability to easily return back to the curriculum, this change opens them in a new tab by default
Module: JS1 Week(s): 1
Checklist
- [X] I have read the contributing guidelines
- [X] I have checked my spelling and grammar with an automated tool
- [X] I have previewed my changes to check the markdown renders as I intend
- [X] I have run my code to check it works
- [X] My changes follow our Style Guide
Description
I have modified the <a> tags in layouts/partials/block/pullreq.html to include target="_blank" so that pull requests open in a new tab/window.
Who needs to know about this?
@SallyMcGrath @Dedekind561
Rendered Pages
Deploy Preview for cyf-curriculum ready!
| Name | Link |
|---|---|
| Latest commit | 33bd8030fe67cdc2837ed5f6af7302576f288da3 |
| Latest deploy log | https://app.netlify.com/sites/cyf-curriculum/deploys/650ec2576fd5ae000891378b |
| Deploy Preview | https://deploy-preview-299--cyf-curriculum.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 92 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 91 (no change from production) PWA: 70 (no change from production) View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
@Louuu just checking you saw these comments. 🙏 🤗
This is stale - re-open if you wish to pursue it.
