Clément de Tastes
Clément de Tastes
Hello, looks good, can you add a test case for this ?
Also the doc shall be updated :)
Having a look
A thing that occurred to me is that an application can have multiple stages. It lacks semantics to indicate that we intend to inject the primary stage, maybe we shall...
Why not just provide a static accessor from an utility class, that would ease usage. I don't see real relevance in injecting the accessor. If stage is not created yet,...
Yes indeed, if we want injection I don't see a better idea yet.
> > Yes indeed, if we want injection I don't see a better idea yet. > > How about adding `primaryStage` to `FxViewRepository`? Sounds like a good idea !
> I think it is better to remove adding/applying stylesheets by `FxViewRepository/@FxView` entirely, because stylesheets can be added to FXML file directly: > > `/fxml/login.fxml`: > > ``` > >...
@all-contributors add @Eng-Fouad for code