deezcord icon indicating copy to clipboard operation
deezcord copied to clipboard

Rich Presence doesn't work anymore

Open b1sergiu opened this issue 4 years ago • 20 comments

Hey there, the Rich Presence API that you're using is deprecated and no longer works.

I forked your project and fixed the issue by using Lachee's API. Maybe we should consider merging sometime?

Thanks

b1sergiu avatar Apr 09 '20 10:04 b1sergiu

@CodeMyst don't know if you'll see this so I'm mentioning you

b1sergiu avatar Apr 13 '20 19:04 b1sergiu

Thanks for mentioning me, otherwise I wouldn't have seen it. It's awesome that you forked my project and you improved it. My version had a lot of issues.

I would be very open to merging and would like to contribute some code if needed as well. Tomorrow I'll check out your project and we can go from there. Do you have any ideas on how we should merge the projects into one?

CodeMyst avatar Apr 13 '20 19:04 CodeMyst

We could keep Avalonia however I don't know how it works or how to update it properly. I'm currently planning to change the Deezer API since the old one seems to throw an SSL error after you use it for 20-30 minutes.

b1sergiu avatar Apr 13 '20 20:04 b1sergiu

Huh I didn't notice that with the API before. Unfortunately that's the only one you can use.

Also I'll look into some other UI options and check Avalonia again, in the current repo Avalonia doesn't work on some machines for some reason.

CodeMyst avatar Apr 13 '20 20:04 CodeMyst

Unfortunately that's the only one you can use.

What about E.Deezer?

b1sergiu avatar Apr 13 '20 20:04 b1sergiu

From the looks of it, it's just a wrapper around the official Deezer API.

CodeMyst avatar Apr 13 '20 20:04 CodeMyst

Might fix the issue, you never know lol

b1sergiu avatar Apr 13 '20 20:04 b1sergiu

I'll try reproducing the issue you had first.

CodeMyst avatar Apr 13 '20 20:04 CodeMyst

I can fix the code and you could add a proper UI and we could merge those in a future Deezcord 2.0 update. What do you think?

b1sergiu avatar Apr 13 '20 20:04 b1sergiu

fine by me!

-------- Original message -------- From: Sergiu Bucur [email protected] Date: 13/04/2020 22:58 (GMT+01:00) To: CodeMyst/deezcord [email protected] Cc: CodeMyst [email protected], State change [email protected] Subject: Re: [CodeMyst/deezcord] Rich Presence doesn't work anymore (#6)

I can fix the code and you could add a proper UI and we could merge those in a future Deezcord 2.0 update. What do you think?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/CodeMyst/deezcord/issues/6#issuecomment-613094829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4Y7JGSCEMYQ2XXEFJDCHDRMN4H5ANCNFSM4METHMEA.

CodeMyst avatar Apr 13 '20 21:04 CodeMyst

@b1sergiu I made a basic avalonia app in the v2 branch, could you submit a PR with your code into it and i'll hook it up?

CodeMyst avatar Apr 21 '20 20:04 CodeMyst

I'm not yet ready, I'll try to finish the project tomorrow. I had to contact the E.Deezer developer and it took a long time

b1sergiu avatar Apr 21 '20 20:04 b1sergiu

Hmm okay, I'm still pretty certain we don't need an api wrapper like E.Deezer but I'll do some tests tomorrow.

CodeMyst avatar Apr 21 '20 20:04 CodeMyst

Hey, I don't think I'm going to use E.Deezer anymore. I find it hard to use and it's barely documented at all. Should I just leave the old API as is?

b1sergiu avatar Apr 24 '20 10:04 b1sergiu

Sure

CodeMyst avatar Apr 24 '20 13:04 CodeMyst

Hey, I'm back. Sorry for the wait. I will update the code and issue a pull request.

b1sergiu avatar May 11 '20 09:05 b1sergiu

Done. Here it is

b1sergiu avatar May 13 '20 20:05 b1sergiu

will check the PR tomorrow if i can!

-------- Original message -------- From: Sergiu Bucur [email protected] Date: 13/05/2020 22:39 (GMT+01:00) To: CodeMyst/deezcord [email protected] Cc: CodeMyst [email protected], State change [email protected] Subject: Re: [CodeMyst/deezcord] Rich Presence doesn't work anymore (#6)

Done. Here it ishttps://github.com/CodeMyst/deezcord/pull/7

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/CodeMyst/deezcord/issues/6#issuecomment-628233793, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4Y7JEK7DMSD3FISMZQS7TRRMARHANCNFSM4METHMEA.

CodeMyst avatar May 13 '20 20:05 CodeMyst

also, from a quick glance, it seems you leaked your api keys... :/

CodeMyst avatar May 13 '20 20:05 CodeMyst

...fuck my life

b1sergiu avatar May 13 '20 21:05 b1sergiu