CodeHub icon indicating copy to clipboard operation
CodeHub copied to clipboard

Fix grammar in thank-you

Open philipmw opened this issue 5 years ago • 3 comments

philipmw avatar Jun 13 '20 03:06 philipmw

I agree

On Saturday, June 13, 2020, Philip M. White [email protected] wrote:

@philipmw commented on this pull request.

In CodeHub.iOS/ViewControllers/Application/SupportViewController.cs https://github.com/CodeHubApp/CodeHub/pull/676#discussion_r439776316:

@@ -31,7 +31,7 @@ public override void ViewDidLoad() var sendEmail = new BigButtonElement("Email Support", Octicon.Mail); var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened);

  •        HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!";
    
  •        HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!";
    

Hi, Rexogamer. I am new to this project, so can you please clarify for me. What is your affiliation with this project? Are you offering your opinion in an official capacity, rejecting my current PR?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/pull/676#discussion_r439776316, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMD4GWTNHM22S63FOTVV2T3RWQBRTANCNFSM4N4ZLU3A .

cadkins052 avatar Jun 14 '20 03:06 cadkins052

Thank you

On Saturday, June 13, 2020, cadkins052 [email protected] wrote:

I agree

On Saturday, June 13, 2020, Philip M. White [email protected] wrote:

@philipmw commented on this pull request.

In CodeHub.iOS/ViewControllers/Application/SupportViewController.cs https://github.com/CodeHubApp/CodeHub/pull/676#discussion_r439776316:

@@ -31,7 +31,7 @@ public override void ViewDidLoad() var sendEmail = new BigButtonElement("Email Support", Octicon.Mail); var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened);

  • HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!";
  • HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!";

Hi, Rexogamer. I am new to this project, so can you please clarify for me. What is your affiliation with this project? Are you offering your opinion in an official capacity, rejecting my current PR?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/pull/676#discussion_r439776316, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ AMD4GWTNHM22S63FOTVV2T3RWQBRTANCNFSM4N4ZLU3A> .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/pull/676#issuecomment-643711364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMD4GWT4AJNEWZYBRTEOECDRWQ5PNANCNFSM4N4ZLU3A .

cadkins052 avatar Jun 14 '20 03:06 cadkins052

取消订阅

------------------ 原始邮件 ------------------ 发件人: "CodeHubApp/CodeHub" @.>; 发送时间: 2021年8月30日(星期一) 中午1:37 @.>; @.***>; 主题: Re: [CodeHubApp/CodeHub] Fix grammar in thank-you (#676)

@ros2-ship approved this pull request. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

GgumWorld avatar Aug 30 '21 07:08 GgumWorld