serverless-express icon indicating copy to clipboard operation
serverless-express copied to clipboard
verified publisher icon CodeGenieApp

[Bug]: `ConfigureParams` type is out-of-date.

Open damienwebdev opened this issue 4 years ago • 4 comments

I was attempting to add a custom eventSource and was getting typehint failures as the eventSource isn't defined in the ConfigureParams type.

https://github.com/vendia/serverless-express/blob/mainline/src/configure.d.ts

damienwebdev avatar Feb 05 '21 14:02 damienwebdev

Thanks for the report. Could you send a PR? 🙏

brettstack avatar Feb 05 '21 21:02 brettstack

I won't have time to.

damienwebdev avatar Feb 05 '21 22:02 damienwebdev

I have the same issue.

We want to use appsync, cognito using eventSource. I'm always rooting for you~

psyrenpark avatar Feb 09 '21 07:02 psyrenpark

Hi @psyrenpark could you clarify? Do you want to use Serverless Express for cognito hooks and AppSync resolvers? If you send a PR with what you want to do, (including a Serverless Framework or SAM template with Cognito and AppSync) I can easily add support for the event sources

brettstack avatar Feb 09 '21 09:02 brettstack