Profile input interest error.

[frankbellocchio]

If you put in SQL as an interest in your profile it causes major errors and won't allow your profile to be saved. This tells me that the String error handling is not that robust. When I removed that SQL term it worked again.

[themightychris]

Thanks for the report @frankbellocchio !

This appears to have to do with how topic and tech tags are implemented. "SQL" existed as a topic tag and trying to create it as a tech tag would violate a database constraint that the profile editor doesn't have a handler for. I moved SQL to be a tech tag instead of a topic tag so you should be able to add it as a technology you're interested in now.

I wonder if the solution here is either to 1) allow the same tag to be a tech and a topic or 2) keep preventing it but throw a friendly error or 3) keep preventing it but just silently switch it to whichever category the tag already exists in. Any thoughts?

[frankbellocchio]

I am generally interested in SQL as a technology and as a topic. So both would be nice. However I changed it to technology as I thought that matched better just like API. It could be both for me.

Is there a input rule or handler for sware words also? Just wondering because generally my experience with forums is that they have routines to cleanse the input before errors. I would allow it as a topic or suggest that it be used as a technology and the topic could be database programming.

I would say a soft error would be an improvement. Most people would not know to remove the term SQL or that the code is trying to prevent a hacking attack with someone trying to execute a SQL script in the form.. On Aug 20, 2015 11:16 PM, "Chris Alfano" [email protected] wrote:

Thanks for the report @frankbellocchio https://github.com/frankbellocchio !

This appears to have to do with how topic and tech tags are implemented. "SQL" existed as a topic tag and trying to create it as a tech tag would violate a database constraint that the profile editor doesn't have a handler for. I moved SQL to be a tech tag instead of a topic tag so you should be able to add it as a technology you're interested in now.

I wonder if the solution here is either to 1) allow the same tag to be a tech and a topic or 2) keep preventing it but throw a friendly error or 3) keep preventing it but just silently switch it to whichever category the tag already exists in. Any thoughts?

— Reply to this email directly or view it on GitHub https://github.com/CfABrigadePhiladelphia/laddr/issues/83#issuecomment-133263631 .

[titlecharacter]

I don't know that I have a strong opinion about 1 vs 3, but I don't think an error message is appropriate: Friendly or not, the user did nothing wrong. They said "hey, I'm interested in SQL" and they're rewarded with a weird error message about one tag among (hopefully) many. (I actually don't know that I see topics & tech as hugely different, particularly in a newbie-rich learning zone like a brigade, where a lot of people are generally interested in X, hear about a need for X, and end up picking up some basic X skills along the way.

[themightychris]

I'm inclined to go with #3. They're all just tags at the end of the day, the split is just for easier browsing. Topics are intended to be real world domains in which problems are addressed. If someone is interested in a tech as a topic they're just interested in the tech On Aug 21, 2015 9:36 AM, "Ben Novack" [email protected] wrote:

I don't know that I have a strong opinion about 1 vs 3, but I don't think an error message is appropriate: Friendly or not, the user did nothing wrong. They said "hey, I'm interested in SQL" and they're rewarded with a weird error message about one tag among (hopefully) many. (I actually don't know that I see topics & tech as hugely different, particularly in a newbie-rich learning zone like a brigade, where a lot of people are generally interested in X, hear about a need for X, and end up picking up some basic X skills along the way.

— Reply to this email directly or view it on GitHub https://github.com/CfABrigadePhiladelphia/laddr/issues/83#issuecomment-133426546 .

[frankbellocchio]

I could agree with that. If someone enters SQL it just becomes a tech and the user never sees an error. On Aug 21, 2015 10:09 AM, "Chris Alfano" [email protected] wrote:

I'm inclined to go with #3. They're all just tags at the end of the day, the split is just for easier browsing. Topics are intended to be real world domains in which problems are addressed. If someone is interested in a tech as a topic they're just interested in the tech On Aug 21, 2015 9:36 AM, "Ben Novack" [email protected] wrote:

I don't know that I have a strong opinion about 1 vs 3, but I don't think an error message is appropriate: Friendly or not, the user did nothing wrong. They said "hey, I'm interested in SQL" and they're rewarded with a weird error message about one tag among (hopefully) many. (I actually don't know that I see topics & tech as hugely different, particularly in a newbie-rich learning zone like a brigade, where a lot of people are generally interested in X, hear about a need for X, and end up picking up some basic X skills along the way.

— Reply to this email directly or view it on GitHub < https://github.com/CfABrigadePhiladelphia/laddr/issues/83#issuecomment-133426546

.

— Reply to this email directly or view it on GitHub https://github.com/CfABrigadePhiladelphia/laddr/issues/83#issuecomment-133437164 .