clean-and-green-philly icon indicating copy to clipboard operation
clean-and-green-philly copied to clipboard

Task: Implement Find Properties filter option for property market values

Open hannahvy opened this issue 1 year ago • 11 comments

Describe the task

Currently, there is not an option for users to filter vacant properties by estimated market value. We will implement a filter option in which users can 1) input their own custom value for minimum and maximum entry fields and/or 2) select from a dropdown of provided market values for the minimum and maximum entry fields.

Acceptance Criteria

  • Users can input custom values
  • Can select from a dropdown of pre-defined market values
  • Can clear the entry field by clicking "Clear"
  • Can confirm their selections by clicking "Done"

Additional context

Screenshot 2024-11-07 at 5 47 52 PM

hannahvy avatar Nov 07 '24 22:11 hannahvy

@bacitracin quick question about the input field, would we need a visual label here? Would the "Market Value" act as the label or do you think it would be beneficial to include a visual label for the min value and max value input fields? Maybe just a floating label can work. For example, this NEXTUI input: https://nextui.org/docs/components/input#usage

Amberroseweeks avatar Nov 08 '24 02:11 Amberroseweeks

@Amberroseweeks Good question! A visible label is definitely necessary here for Min Value & Max Value. Once you pick a value the Min Value/ Max Value text disappears. It being min/max from left to right seems obvious to us but adding the label will help with cognitive load, and if screenreader or zoomtext users get disoriented.

Ideally the label would be outside of the input and not move around, but if you use a floating label and 1) it's always visible 2) sounds decent on a screenreader it should be fine. In the first example on that page it reads out as "Email email edit your email edit text email" which you'd want to avoid.

bacitracin avatar Nov 08 '24 04:11 bacitracin

This issue has been marked as stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Dec 28 '24 00:12 github-actions[bot]

I'd like to pick this up!

DonovanAndrews300 avatar Jan 01 '25 14:01 DonovanAndrews300

@DonovanAndrews300 assigned! Happy new year!

CodeWritingCow avatar Jan 01 '25 15:01 CodeWritingCow

Thanks, Happy New Year!

DonovanAndrews300 avatar Jan 01 '25 15:01 DonovanAndrews300

@DonovanAndrews300 any update on this?

CodeWritingCow avatar Feb 07 '25 04:02 CodeWritingCow

Going to look into this one @nlebovits.

StubberG3 avatar Mar 29 '25 22:03 StubberG3

@StubberG3 sounds great! Coordinate with @cfreedman, who's our new FE lead

nlebovits avatar Mar 30 '25 18:03 nlebovits

@StubberG3 thanks for coming in to contribute the project. I'm just finishing up a bit of a refactor of the way the filters are implemented that will affect this ticket, so just keep an eye out for that in a couple days while you're familiarizing yourself with the repo.

cfreedman avatar Mar 30 '25 19:03 cfreedman

Hi, I have an older branch for this that i'd like to revisit and work on, considering the new refactor of filters as well. If this ticket is still open, can I be reassigned this task? I am trying to get back in action after maternity leave!

Thanks!

Amberroseweeks avatar Apr 30 '25 14:04 Amberroseweeks