node-promise-mysql icon indicating copy to clipboard operation
node-promise-mysql copied to clipboard

Pool.release defined but not implemented

Open larserik opened this issue 2 years ago • 1 comments

The function release() is defined in the Pool class https://github.com/CodeFoodPixels/node-promise-mysql/blob/7c075145cc981ae945ee612181e28b2c74f3e843/index.d.ts#L99

But there is no release function in the implementation pool.js https://github.com/CodeFoodPixels/node-promise-mysql/blob/7c075145cc981ae945ee612181e28b2c74f3e843/lib/pool.js

Is it a mistake to have it in the definition? Or is it missed to be implemented?

For example Visual Studio Code will give the release function as an autocomplete suggestion. But if you use it you will get the error TypeError: _a.release is not a function

larserik avatar Dec 26 '22 15:12 larserik

Hi @larserik - the readme states the following; not sure if this is relevant to your issue:

Upgrading from v4 to v5
The pool.releaseConnection has been removed, please use poolConnection.release instead.

emilh91 avatar Dec 23 '24 15:12 emilh91