CodeEditSourceEditor icon indicating copy to clipboard operation
CodeEditSourceEditor copied to clipboard

✨ Text selection with round corners

Open wayou opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Text selection with round corner like in VSCode.

Describe alternatives you've considered

VSCode

Additional context

Screen Shot 2022-05-19 at 13 00 29

wayou avatar May 19 '22 05:05 wayou

Hi @wayou, this feature sounds like a great idea, but we need consistency throughout our app and it is supposed to have a mimicked UI of Xcode. Xcode doesn't have round text selection. I might reconsider opening a PR for this if you tell me why we need round text selection. Every CodeEdit feature is backed by why it was implemented. Also, please provide a detailed response for each question, not just a few words.

ghost avatar May 19 '22 13:05 ghost

Thank you for your suggestion @wayou. This looks very nice and would make a great addition to CodeEdit. As this is not the default behavior of Xcode, if we did something like this it would need to be under a togglable setting disabled by default.

@maxsuaudeau Anyone is more than welcome to open an issue as long as it pertains to forward development of the project which this issue does.

austincondiff avatar May 19 '22 14:05 austincondiff

@austincondiff oh ok

ghost avatar May 19 '22 14:05 ghost

i think if we implement this feature, it needs to be disabled by default. See this stack overflow post, it might help https://stackoverflow.com/questions/16362407/nsattributedstring-background-color-and-rounded-corners

0xWDG avatar May 19 '22 14:05 0xWDG

Hi @maxsuaudeau, glad to hear your reply. I'm long for such an editor with native experience and Xcode like well designed UI. But Xcode lacks of some convenient behavior like rich language support, format on save, etc.

I think the round text selection looks so great which is much more mac style, so I wonder if we can have it in CodeEdit.

wayou avatar May 20 '22 03:05 wayou