CodeEditSourceEditor icon indicating copy to clipboard operation
CodeEditSourceEditor copied to clipboard

🐞 Suggestion window fails to draw

Open nkleemann opened this issue 4 months ago • 3 comments

Description

Everytime after using the editor with the suggestion feature for a short period of time (5-15 appereances of the panel), the panel window just doesnt appear anymore, but pressing "TAB" or "ENTER" still inserts suggestions at the cursor.

In the XCode console I get:

Warning: -[NSWindow makeKeyWindow] called on <NSWindow: 0x401330240> windowNumber=151f8 which returned NO from -[NSWindow canBecomeKeyWindow].

This happens for the latest version still, with the new "Suggestion Window Fixes" PR merged.

To Reproduce

  1. Use the example with the mock completions for a longer period of time
  2. Let the panel appear and disappear 10-20x

Expected Behavior

The suggestions window should always render, and IF something fails to render, the viewmodel should refrain from inserting completions.

Version Information

CodeEditSourceEditor: latest main branch macOS: 15.5 (24F74) Xcode: 16.4 (16F6)

Additional Context

No response

Screenshots

No response

nkleemann avatar Aug 31 '25 05:08 nkleemann

That's really odd, it sounds like the suggestion window is being created but maybe is stuck behind something? I'm not sure what would cause that.

thecoolwinter avatar Sep 16 '25 19:09 thecoolwinter

Oh I just noticed this too. And what's weird is that you can still "navigate" the suggestions and pick one, but it does not render:

https://github.com/user-attachments/assets/e95e9ad4-f6aa-476f-9d23-54254a9f9227

(And I got LSP working in this btw, super cool!)


And you can see it when it's actually working: https://github.com/user-attachments/assets/4c24fcce-9d3c-466c-ae86-b19d00db09d0

(I need to fix the insert that's adding an extra .)

lucasmotta avatar Sep 28 '25 21:09 lucasmotta

@nkleemann it would be great if you could test this PR claude just created - for me it seems to be working fine, even thou I still see the same warning in the logs.

lucasmotta avatar Sep 29 '25 17:09 lucasmotta