CodeEditSourceEditor icon indicating copy to clipboard operation
CodeEditSourceEditor copied to clipboard

✨ Configuration to toggle line numbers visibility

Open vitalyster opened this issue 2 years ago • 10 comments

Is your feature request related to a problem? Please describe.

Line numbers make UI bloated, we have line indicator in status bar

Describe the solution you'd like

Please hide line numbers by default

Describe alternatives you've considered

At least there should be an option to hide

Additional context

Screenshot 2023-01-13 at 03 52 24

vitalyster avatar Jan 13 '23 00:01 vitalyster

We probably won't hide the line numbers by default but having an option to turn them off seems like a good idea 👍

lukepistrol avatar Jan 13 '23 01:01 lukepistrol

@lukepistrol - I'll take this one on.

ben-p-commits avatar Jan 23 '23 20:01 ben-p-commits

Should we provide the ability to hide line numbers or hide the entire gutter which includes indications for code folding, code review, etc.? Maybe both (could be too much though)?

austincondiff avatar Jan 23 '23 20:01 austincondiff

Anecdotal- but I believe people who ditch line numbers are probably good with eschewing folding, review- etc.

ben-p-commits avatar Jan 23 '23 20:01 ben-p-commits

image then again...

xcode goes all the way

image

ben-p-commits avatar Jan 23 '23 20:01 ben-p-commits

@austincondiff, perhaps we add the options as separate enhancements when the respective functionality is implemented?

Hard to say whether the RulerView is going to be the container for those future features like a code ribbon, or if sibling views are needed for them.

ben-p-commits avatar Jan 23 '23 20:01 ben-p-commits

I like that. If Xcode provides the ability to show/hide each thing individually, we should do the same.

austincondiff avatar Jan 23 '23 20:01 austincondiff

@austincondiff, So- do we wait for those features to be implemented? 😆

ben-p-commits avatar Jan 23 '23 21:01 ben-p-commits

https://github.com/CodeEditApp/CodeEditTextView/pull/124

@austincondiff , @lukepistrol, PR in the pocket.

ben-p-commits avatar Jan 23 '23 21:01 ben-p-commits

@ben-p-commits No, just making a comment that we should hide just the line numbers here and the others as they get implemented. 😉

austincondiff avatar Jan 23 '23 23:01 austincondiff