CodeEditLanguages icon indicating copy to clipboard operation
CodeEditLanguages copied to clipboard

Add `ERB`/`EJS` Grammar

Open cengelbart39 opened this issue 2 years ago • 2 comments

Description

Adds ERB/EJS grammar via tree-sitter-embedded-template.

Related Issues

  • #10

Depending on the desire to add more languages to CELanguages, it could close this issue as well.

Checklist

  • [x] I read and understood the contributing guide as well as the code of conduct
  • [x] The issues this PR addresses are related to each other
  • [x] My changes generate no new warnings
  • [x] My code builds and runs on my machine
  • [x] My changes are all related to the related issue above
  • [x] I documented my code

cengelbart39 avatar Oct 02 '23 20:10 cengelbart39

With the current implementation, there are highlighting issues with ERB and EJS.

For ERB, Ruby doesn't highlight properly (left ERB, right Ruby) Screenshot_2023-09-24_at_9 42 34_AM

While HTML highlighting works, it isn't perfect either, with some closing tags not being highlighted Screenshot_2023-09-24_at_9 43 09_AM

It's a similar case for EJS, with JavaScript not highlighting, while HTML highlighting is the same as ERB (left EJS, right JS) Screenshot_2023-09-24_at_9 43 23_AM

While I have mentioned this in the Discord, I felt I should include it here for anyone waiting on this PR to not be a draft anymore.

cengelbart39 avatar Oct 18 '23 15:10 cengelbart39

I updated the PR to keep up with changes to the package since created.

Between updates to CE, CEL, CETX, and CESE, the highlighting issue persists.

cengelbart39 avatar Jan 23 '24 01:01 cengelbart39