CodeEdit 🐞 Theme does not sync with system appearance

Description

Theme does not sync with system appearance. If I have a dark system appearance, when I first open CodeEdit, I have a light theme. This should not happen unless I've selected it while in dark mode.

To Reproduce

In System Preferences, select dark mode.
Open CodeEdit for the first time.
Notice the light syntax theme.

Expected behavior

The selected theme should be the default dark theme on launch if my appearance is dark.

If the system appearance ever changes, it should be the preferred light theme. If I ever change my theme while in this system appearance, that will then become my new preferred theme for that system appearance. If no preference exists, it will have a default theme for each appearance type (light and dark).

Considerations

User can change application appearance to Light or Dark regardless of system appearance. Themes need to follow application appearance.

This behavior should only happen when this checkbox is checked (checked by default).

Version information

CodeEdit: [e.g. 1.0] Hash: [e.g. 87a5b3f4c18238c0d06cbfce595e1ca9b11cfd8e] MacOS: [e.g. 12.3.0] Xcode: [e.g. 13.3]

Additional context

No response

Aug 03 '22 22:08 austincondiff

I think I can take this on. Just wondering; If I have my theme set to Github Dark and switch my system appearance to 'light', do we want to switch the theme to Github Light, or can we just take the first 'light' theme in the list?

Aug 27 '22 22:08 adsalad

If the user had previously selected GitHub Light while in light mode, then it would change to GitHub Light. Otherwise it would go to the default Xcode Light until the user selects a theme while in light mode.

So essentially it remembers what theme you had selected in dark mode and light mode independently.

Aug 28 '22 03:08 austincondiff

I would like to work on this issue. Can you please assign this to me

Sep 02 '22 21:09 amit-srt

@adsalad are you currently working on this or should we give it to @amit-srt?

Sep 03 '22 02:09 austincondiff

Thanks for asking. I was making good progress on it, but reached an odd roadblock. Ill stash the changes for now and we can see what @amit-srt comes up with!

I can also share what I did so far @amit-srt.

Sep 03 '22 18:09 adsalad

@amit-srt Please respond if you are still up for this. You responded with this same message on quite a few issues and just want to make sure if this request is legitimate (we've gotten spam issues and comments in the past so we just need to confirm).

Sep 04 '22 07:09 austincondiff

Alright, in that case I will continue to work on this. I've moved past my blocker and hope to have a PR out soon.

Sep 07 '22 02:09 adsalad

@adsalad thanks for following up on this. Looking forward to it.

Sep 07 '22 05:09 austincondiff

Think we can close this one now.

Sep 28 '22 22:09 adsalad