CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

🐞 Inconsistencies in Source Control Navigator: Local changes

Open Angelk90 opened this issue 2 years ago • 7 comments

Description

As seen in the image when a file is selected, the icon is not seen correctly.

Furthermore:

  • The information type of the file is missing if it is an addition, a modified file or other. example: U or M
  • For example the files that are inside .idea, on xcode only the folder is displayed and not the files. On xcode instead the files are displayed.
Schermata 2022-05-25 alle 11 35 54

Expected behavior

Schermata 2022-05-25 alle 11 35 42

Version information

CodeEdit: [e.g. 1.0] Hash: [e.g. 61771ab39b588e37b61990ff0b4d209499c22da6] MacOS: [e.g. 12.3.0] Xcode: [e.g. 13.3]

Angelk90 avatar May 25 '22 09:05 Angelk90

The folders not showing is not an bug, I specifically set it like that because xcode only shows the folder with files etc... And not the changed file and it's more convenient knowing exactly what files was changed/created instead of in what folder it happened.

nanashili avatar May 25 '22 10:05 nanashili

@nanashili : I didn't mean it was a bug, I just noticed this thing I wanted to point it out to know what you thought.

Angelk90 avatar May 25 '22 11:05 Angelk90

@nanashili : I didn't mean it was a bug, I just noticed this thing I wanted to point it out to know what you thought.

But yea showing the files instead of the folder for me is much more easier

nanashili avatar May 25 '22 12:05 nanashili

@nanashili : I don't understand why, xcode does this.

What do you think of a possible version like this with files that are in the same dir?

Schermata 2022-05-25 alle 14 34 19

Angelk90 avatar May 25 '22 12:05 Angelk90

We could do something like GitHub, but will need to check if git supports it.

nanashili avatar May 25 '22 13:05 nanashili

Also it looks like the row density is off. It should match that of the project navigator.

austincondiff avatar May 25 '22 14:05 austincondiff

And as @lilingxi01 mentioned in https://github.com/CodeEditApp/CodeEdit/pull/638#pullrequestreview-985273645, the left and right padding is a little off...

CleanShot 2022-05-25 at 14 10 14@2x

Compare with Xcode here...

image

This will not be fixed in #638, as mentioned here https://github.com/CodeEditApp/CodeEdit/pull/638#issuecomment-1137758327

austincondiff avatar May 25 '22 19:05 austincondiff