CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

✨ Preferences Option To Toggle Auto-Save

Open austincondiff opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe.

Some people may not like auto-save.

Describe the solution you'd like

We need the ability for users to toggle on and off auto-save.

austincondiff avatar May 09 '22 22:05 austincondiff

@austincondiff What do you mean? Why would users not want to autosave? Then, when they close the window, all their work would be gone.

ghost avatar May 18 '22 23:05 ghost

@SwiftUILabs A Discord comment mentioned that it's changing the file 4 times upon closing, without any changes being made.

https://discord.com/channels/951544472238444645/954084547694325861/973573320765235270

jevonmao avatar May 19 '22 00:05 jevonmao

@SwiftUILabs There are many reasons why users may not want autosave enabled. If this causes many unnecessary builds or the user is simply not used to it they may want to manually save.

One thing to note, when attempting to close an unsaved file we should prompt them to either save, discard, or cancel similar to other editors.

austincondiff avatar May 19 '22 03:05 austincondiff

@austincondiff Got it. I thought you meant that we would add an autosave toggle but not an in-editor autosave toggle that lets the user click a button to save.

ghost avatar May 19 '22 13:05 ghost

@austincondiff I would like to work on this issue. Could you assign this to me?

sk409 avatar Sep 19 '22 08:09 sk409

@austincondiff I would like to work on this issue. Could you assign this to me?

I have assigned you, thanks for working on this issue 🥇

0xWDG avatar Sep 19 '22 08:09 0xWDG

@wdg Thank you for assigning😄

sk409 avatar Sep 19 '22 09:09 sk409

Sorry, I was asleep when you commented. 😄 Thanks for stepping in @wdg!

austincondiff avatar Sep 19 '22 18:09 austincondiff

@austincondiff @wdg I submitted a PR(#763). Please review this PR when you have time.

By the way, Should I ask for a review in the issue comment every time? Since PR template has Review requested checklist.

sk409 avatar Sep 23 '22 09:09 sk409