CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard
verified publisher icon CodeEditApp

✨ Custom Font Settings

Open austincondiff opened this issue 3 years ago • 11 comments

We need a custom font setting in CodeEdit.

  • [x] The editor and terminal should both default to SF Mono.
  • [x] The editor and terminal should have the following separate font settings.
    • [x] Font family
    • [x] Font size
    • [x] Font weight
    • [ ] Line height
  • [x] The terminal by default should use the editors font settings (with the exception of line height, should default to the same as the font size) but can be set to be different from the editors setting.

Use case: I use a powerline zsh theme which requires a custom font to display correctly. I see this... image when it should look like this... image

austincondiff avatar Mar 23 '22 05:03 austincondiff

I will add the font settings tab to the Preference view

underthestars-zhy avatar Mar 23 '22 09:03 underthestars-zhy

Terminal font settings working for now

lukepistrol avatar Mar 23 '22 14:03 lukepistrol

They do! image

There is no editor font settings though

austincondiff avatar Mar 23 '22 15:03 austincondiff

@austincondiff working on implementing an ANSI color picker now #219

lukepistrol avatar Mar 23 '22 16:03 lukepistrol

There is no editor font settings though

Yeah I guess @MarcoCarnevali should take a look at the editor font selector since he's working on the editor and I don't want to mess things up

lukepistrol avatar Mar 23 '22 16:03 lukepistrol

It would also be nice to have an option that enables font ligatures!

jakoritarleite avatar Mar 23 '22 17:03 jakoritarleite

@lukepistrol We should be using the syntax highlighting theme the user has selected to also highlight the terminal.

austincondiff avatar Mar 23 '22 22:03 austincondiff

We are just waiting on the ability to change the line height for both the editor and the terminal to be able to close this. The editor should default to 16px/1.6em/160% based on a 10px font size, and terminal should default to 10px/1em/100% (same as font size).

austincondiff avatar Apr 22 '22 19:04 austincondiff

Current line height limit is capped to 2 and that is just too low :c

https://github.com/CodeEditApp/CodeEdit/blob/ff0f796293a2380be6302a3b05e168437ca9adcb/CodeEdit/Features/AppPreferences/Sections/TextEditingPreferences/TextEditingPreferencesView.swift#L33

nicolasparada avatar Jan 13 '23 22:01 nicolasparada

@nicolasparada What would be an acceptable cap if not 2.0?

austincondiff avatar Jan 13 '23 23:01 austincondiff

Dunno really.

In VSCode, from 0 to 8 means it is a multiplier of the font size. I use 3, and the default font size of 12, meaning the line height is 36.

In VSCode then I increase the whole zoom to 2 (140%) which increases everything up. So maybe I would need 50 of line height.

I bet there are people that like it even more spaced :)

nicolasparada avatar Jan 14 '23 00:01 nicolasparada

Everything in the above checkbox has been implemented. Closing.

austincondiff avatar Feb 17 '23 18:02 austincondiff