CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

Autocomplete Implementation

Open FastestMolasses opened this issue 1 year ago • 3 comments

Description

Adds first iteration of the autocomplete feature.

Related Issues

Checklist

  • [x] I read and understood the contributing guide as well as the code of conduct
  • [x] The issues this PR addresses are related to each other
  • [x] My changes generate no new warnings
  • [x] My code builds and runs on my machine
  • [x] My changes are all related to the related issue above
  • [x] I documented my code

Screenshots

FastestMolasses avatar Dec 18 '24 07:12 FastestMolasses

That last I just pushed should fix build errors. Going to merge once tests are passing and it looks ready to go

thecoolwinter avatar Aug 18 '25 19:08 thecoolwinter

Looks like there's some bug with either requesting completion items or filtering them. If I have a swift script like:

let string = ""
string.spl

The LSP isn't returning split as an option for completions. Super weird, going to investigate more before merging.

thecoolwinter avatar Aug 18 '25 20:08 thecoolwinter

That last commi fixes the issue I mentioned. It turns out that language servers can opt-out of client-side filtering by setting the isIncomplete flag in the item response. This checks for that flag and disables filtering if it's detected.

thecoolwinter avatar Aug 19 '25 16:08 thecoolwinter