CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

feat(themes): Add fuzzy search for filtering and sorting themes in settings

Open tom-ludwig opened this issue 1 year ago • 2 comments

Description

Added a basic fuzzy search feature to the themes settings page (#1760). This utilizes the existing algorithm and will help users find themes much faster.

Related Issues

  • closes #1760

Checklist

  • [x] I read and understood the contributing guide as well as the code of conduct
  • [x] The issues this PR addresses are related to each other
  • [x] My changes generate no new warnings
  • [x] My code builds and runs on my machine
  • [x] My changes are all related to the related issue above
  • [x] I documented my code

Screenshots

Screenshot 2024-06-21 at 11 40 18 PM

tom-ludwig avatar Aug 14 '24 13:08 tom-ludwig

I appreciate the PR, but is this something users want/need? We might do this in the Quick Actions overlay when we get to that point. ⇧⌘A, Type "Theme", press enter, Quick actions then displays a searchable list of all themes for you to choose from. To go back users can press something like Esc or Backspace similar to Raycast.

austincondiff avatar Aug 14 '24 15:08 austincondiff

I completely agree that users would likely use the Quick Action overlay to achieve the same result. However, I believe that every list in an application, regardless of its content, should have a search field if possible. It doesn’t need to be visible at all times, but perhaps we could include a button that reveals a search field when needed.

tom-ludwig avatar Aug 15 '24 18:08 tom-ludwig

Can you update that old screenshot with a new screen recording showcasing your changes?

austincondiff avatar Sep 09 '24 06:09 austincondiff